Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add renku cli to PATH in rstudio #232

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Conversation

olevski
Copy link
Member

@olevski olevski commented Mar 17, 2022

Fixes renku not being present in the PATH of rstudio images.

@olevski
Copy link
Member Author

olevski commented Mar 17, 2022

This project: https://renkulab.io/projects/tasko.olevski/test-r-project-1 uses the image built in this repo. And renku cli works in both rstudio and jupyterlab.

@rokroskar
Copy link
Member

if I'm reading the R Dockerfile correctly, we never actually install renku in there. Should we copy it from the python base image like we do the other python packages here? I guess all that is needed is something like

COPY --from renku_base /home/jovyan/.renku /home/rstudio/.renku

@olevski
Copy link
Member Author

olevski commented Mar 18, 2022

if I'm reading the R Dockerfile correctly, we never actually install renku in there. Should we copy it from the python base image like we do the other python packages here? I guess all that is needed is something like

COPY --from renku_base /home/jovyan/.renku /home/rstudio/.renku

@rokroskar what you describe does happen in the Dockerfile in lines 78 and 79. The link to them did not work. Renku is installed in the home directory and we copy the whole home directory over.

Maybe I misunderstand what you mean though.

@gavin-k-lee
Copy link
Contributor

I verified that the cli is available in that image 👍

@rokroskar
Copy link
Member

@olevski you're totally right I missed it because of the line break 🤦 !!

@olevski
Copy link
Member Author

olevski commented Mar 18, 2022

@rokroskar @gavin-k-lee if you are done testing/reviewing can you approve please?

@olevski olevski merged commit 8cd44bb into master Mar 18, 2022
@olevski olevski deleted the fix-add-renku-to-R-images branch March 18, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants