Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): allow ignoring template rendering errors #3697

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

m-alisafaee
Copy link
Contributor

Description

This PR adds a flag to allow ignoring template rendering errors.

Fixes #3696

@m-alisafaee m-alisafaee marked this pull request as ready for review January 31, 2024 08:30
@m-alisafaee m-alisafaee requested a review from a team as a code owner January 31, 2024 08:30
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7722910941

  • -10 of 19 (47.37%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.04%) to 85.137%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/domain_model/template.py 7 17 41.18%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/core/init.py 1 92.86%
renku/core/migration/migrate.py 1 82.14%
renku/core/template/usecase.py 1 89.71%
renku/core/workflow/activity.py 1 93.61%
renku/ui/cli/init.py 1 96.95%
renku/ui/cli/service.py 1 78.31%
renku/command/rollback.py 2 78.7%
Totals Coverage Status
Change from base Build 7584575825: -0.04%
Covered Lines: 26642
Relevant Lines: 31293

💛 - Coveralls

@m-alisafaee m-alisafaee merged commit 088ce15 into develop Feb 5, 2024
32 checks passed
@m-alisafaee m-alisafaee deleted the 3696-template-render-crash branch February 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Crash when rendering template fails during project creation
3 participants