Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when rendering template fails during project creation #3696

Closed
m-alisafaee opened this issue Jan 26, 2024 · 0 comments · Fixed by #3697
Closed

Crash when rendering template fails during project creation #3696

m-alisafaee opened this issue Jan 26, 2024 · 0 comments · Fixed by #3697

Comments

@m-alisafaee
Copy link
Contributor

Describe the bug
We try to render all project files as Jinja templates when initializing a project. If a files isn't a valid Jinja template then the rendering fails causing the project creation to fail.

To Reproduce
renku init -s https://gitlab.renkulab.io/mohammad.alisafaee/ammo-template -r 8fe97f4 test

Expected behavior
If a file cannot be rendered, we should catch the error and print a warning for users and allow the project creation to continue.

We can also mark some files as not-to-be-rendered in the template manifest but this requires more work on the user side and makes template creation more complex.

Additional context
https://renku.discourse.group/t/unable-to-create-a-renku-project-from-a-custom-renku-template-and-a-specific-commit/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant