Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't fail on exotic git diff types #3632

Merged
merged 4 commits into from
Oct 16, 2023
Merged

fix: don't fail on exotic git diff types #3632

merged 4 commits into from
Oct 16, 2023

Conversation

Panaetius
Copy link
Member

fixes #3616

@Panaetius Panaetius requested a review from a team as a code owner October 4, 2023 13:44
@coveralls
Copy link
Collaborator

coveralls commented Oct 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6529795752

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 105 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.8%) to 86.204%
Files with Coverage Reduction New Missed Lines %
renku/command/schema/calamus.py 1 72.58%
renku/core/dataset/providers/api.py 1 83.26%
renku/core/dataset/providers/dataverse.py 1 88.86%
renku/core/workflow/activity.py 1 93.93%
renku/ui/cli/init.py 1 96.9%
renku/ui/service/utils/callback.py 1 88.46%
renku/core/util/git.py 2 86.08%
renku/core/util/os.py 2 88.38%
renku/core/dataset/context.py 3 91.43%
renku/core/dataset/dataset.py 3 85.34%
Totals Coverage Status
Change from base Build 6510222479: 0.8%
Covered Lines: 26462
Relevant Lines: 30697
💛 - Coveralls

m-alisafaee
m-alisafaee approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Panaetius Panaetius enabled auto-merge (squash) October 16, 2023 06:21
@Panaetius Panaetius merged commit 160620c into develop Oct 16, 2023
22 of 25 checks passed
@Panaetius Panaetius deleted the fix/git-diff-types branch October 16, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
documentation:pending
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing "U" ChangeType for git diffs
3 participants
@Panaetius @coveralls @m-alisafaee