Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing "U" ChangeType for git diffs #3616

Closed
Panaetius opened this issue Sep 13, 2023 · 0 comments · Fixed by #3632
Closed

missing "U" ChangeType for git diffs #3616

Panaetius opened this issue Sep 13, 2023 · 0 comments · Fixed by #3632
Assignees
Labels

Comments

@Panaetius
Copy link
Member

Panaetius commented Sep 13, 2023

"U" is a valid git diff change type, but it's missing in the enumhttps://github.com/SwissDataScienceCenter/renku-python/blob/develop/renku/infrastructure/repository.py#L1282 This can cause issues in the check if the repository is dirty.

We should add it. "C" and "X" are also missing (see https://git-scm.com/docs/git-diff#_raw_output_format for all the codes)

@Panaetius Panaetius added kind/bug status/triage Issue needs to be triaged and removed status/triage Issue needs to be triaged labels Sep 13, 2023
@github-project-automation github-project-automation bot moved this to Backlog in renku-python Sep 13, 2023
@Panaetius Panaetius moved this from Backlog to Ready in renku-python Oct 4, 2023
@Panaetius Panaetius moved this from Ready to In Progress in renku-python Oct 4, 2023
@Panaetius Panaetius self-assigned this Oct 4, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in renku-python Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant