-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): ssh setup and key usage #3615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6310115018
💛 - Coveralls |
m-alisafaee
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tasko! I've just added 2 comments regarding a message formatting/wording.
m-alisafaee
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3585
closes #3584
I am not sure that getting into people's ssh configurations to such extent (as we currently do) is maintainable and feasible without a lot of edge cases or bugs. So I decided to simply give a warning when the
renku session ssh-setup
command is used. When I saw this command (including other users from discord) I expected that it would inject ssh keys into the current project. But it does not do this. It only generates/updates stuff in~/.ssh/renku
.I think a more sustainable solution is to step back from doing all this ssh configuration manipulation for users. Because the biggest problem is that it is hard to make things work both with and without using the renku CLI. But we can discuss this further in a separate issue.