Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline ssh access to sessions via the CLI #3585

Closed
olevski opened this issue Aug 11, 2023 · 0 comments · Fixed by #3615
Closed

Streamline ssh access to sessions via the CLI #3585

olevski opened this issue Aug 11, 2023 · 0 comments · Fixed by #3615
Labels
kind/bug status/triage Issue needs to be triaged

Comments

@olevski
Copy link
Member

olevski commented Aug 11, 2023

See https://renku.discourse.group/t/error-cannot-start-session-via-the-notebook-service/870/10

Two main issues:

  • When the CLI is used to access the session via ssh then only a single specific (to that renku deployment) key pair from ~/.ssh/renku is being used to log in, but we should simply try all key pairs in ~/.ssh and in ~/.ssh/renku.
  • Revise/change the logic for how the CLI reports that a session supports SSH. This flag should be true/yes if the ssh daemon is running in the session. Not based on whether whoever is listing the session has access to it via ssh. From testing this feature out it seems that the SSH supported field starts out being set to false/no and when you successfully log in once with ssh then it shows yes.
@olevski olevski added kind/bug status/triage Issue needs to be triaged labels Aug 11, 2023
@github-project-automation github-project-automation bot moved this to Backlog in renku-python Aug 11, 2023
@Panaetius Panaetius moved this from Backlog to Ready in renku-python Aug 31, 2023
@github-project-automation github-project-automation bot moved this from Ready to Done in renku-python Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug status/triage Issue needs to be triaged
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant