-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update AiiDA version, docker, and post-init.sh #79
fix: update AiiDA version, docker, and post-init.sh #79
Conversation
This is expected. The |
When no {% else %}
# Without archive_url, generate profile using `core.sqlite_dos` backend
verdi profile setup core.sqlite_dos \
--profile $aiida_profile \
--first-name "$first_name" \
--last-name "$last_name" \
--email "$email" \
--institution RenkuLab \
--set-as-default \
--non-interactive
{% endif %} I updated the screenshot in my original PR message so that it now actually shows the backend, making the issue clearer. |
Just a ping if one of the maintainers can have a quick look here? Thanks! |
I was in contact with @rokroskar when this started |
btw, for quickly creating a project with this PR, you can use this link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw there is also #8 which would be great to either wrap up or close :) |
Thanks, @ltalirz, for the ping to @rokroskar, and thanks to you for getting back quickly. I'll take care of your comments here, and on #78 in the following days. This is just to confirm that I'm aware of them :) |
c94a469
to
96082ff
Compare
I addressed your changes in my recent commit. Along the way, I tried to restrict the installation to only using
I don't have any opinion on that change. If nothing speaks against it, then I could add it here. 0.25 cpu seems indeed a bit small :D so you let me know. Thanks again, @rokroskar! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GeigerJ2! Just two more small things I noticed...
Thanks again for looking into it @rokroskar! Is this ready to be merged, or are other changes required? |
Pinging @rokroskar, as I'd like to close this soon. Thank you! :) |
Apologies @GeigerJ2 I didn't get to this until now - I just tested the project and it looks good. I still think you might want to consider pinning the image you specify in |
e586751
to
d6e2fa3
Compare
8cab7d4
to
e36f7f2
Compare
Hi @rokroskar, thanks for getting back here. I updated the branch via an interactive rebase, cleaning up the commit history a bit. I found the |
hi @GeigerJ2 - you'll need to uncomment these lines for the CI job to build the image. |
Ah, alright, I see. Though, the project on GitLab is now outdated compared to the state of the code here, as I just regularly built the image locally and pushed it to the registry. Is it fine for now to keep the |
Yep, that's fine! |
Fix and update the RenkuLab AiiDA template
This PR updates the AiiDA template for RenkuLab.
Regarding the broken profile creation on start-up, see PR #78.
Main changes
Dockerfile
is updated, and a new image pinned inrenku.ini
(using the latestrenku
0.22 Python 3.10 baseimage and an AiiDA v2.5.1 installation)
aiida-activate
was removed as the repo is outdatedverdi profile setup
in thepost-init.sh
script, where depending on the presence (absence) of thearchive_url
thesqlite_zip
(sqlite_dos
) backends are usedpsql_dos
) cannot be used due to missingsudo
access → For inspectionsqlite_zip
andsqlite_dos
should be sufficient (frankly, I tried resolving that using theaiida-core
Docker images/Dockerfiles for some time, but didn't manage to make it work, and the effort might not be worth it if we stick to the other backends)aiida-core.services
conda
package, theconsumer_timeout
variable is set, and the version warning disabledexplore
notebook and the READMESome further notes
Currently, the directory where the archive is downloaded is "repo", but one could also use the existing "data" directory instead? I think this ties in with our discussion about
verdi init
, @sphuber and @giovannipizzi. If we manage to merge these changes soon, we could update the setup here - for now it works in the classical way. Pinging @ltalirz and @khsrali here for info as well.If somebody wants to take it for a spin before the merge, you can provide my repository URL and the latest commit SHA of this PR when creating a new RenkuLab project, and fetch the updated template (see screenshot below).
Would be happy about feedback or suggestions for improvement. We also had the idea of providing some additional custom code, which already gives some interesting information about the archive (e.g. as a
pandas
dataframe), though, I think this should be as agnostic of the structure of the data as possible and would warrant a separate PR either way.Lastly, when trying to import this archive after the notebook is created (that is, not providing an
archive_url
initially), I'm getting aNotImplementedError
(see screenshot below), while pure inspection viasqlite_zip
without importing works. I haven't investigated it further so far, but could this be possibly a case in which an automatic migration is required, @superstar54?Creating a project from the template
NotImplementedError
onarchive import