Skip to content

Commit

Permalink
Addressed changes noted by @rokroskar
Browse files Browse the repository at this point in the history
- `aiida-core` dependency is moved directly into Dockerfile
- Version of `aiida-core.services` is pinned to 2.2.2
  for reproducibility e.g. to ensure path to echo
  `consumer_timeout` for RabbitMQ is correct
- 'repo' is renamed to more descriptive 'aiida_data', and added to
  .gitignore
  • Loading branch information
GeigerJ2 committed Apr 15, 2024
1 parent c6ae7e0 commit c94a469
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 14 deletions.
2 changes: 0 additions & 2 deletions aiida/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -336,5 +336,3 @@ tags
.renku.lock
.renku/tmp
.renku/cache

aiida_config.yaml
11 changes: 7 additions & 4 deletions aiida/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,24 @@ RUN apt-get update && \
USER ${NB_USER}

# install the python dependencies
COPY requirements.txt environment.yml /tmp/
COPY environment.yml /tmp/
RUN mamba env update -q -f /tmp/environment.yml

RUN /opt/conda/bin/pip install --upgrade pip && \
/opt/conda/bin/pip install -r /tmp/requirements.txt && \
conda clean -y --all && \
conda env export -n "root"

RUN pip install --upgrade pip

RUN pip install aiida-core~=2.5

# RENKU_VERSION determines the version of the renku CLI
# that will be used in this image. To find the latest version,
# visit https://pypi.org/project/renku/#history.
ARG RENKU_VERSION={{ __renku_version__ | default("2.9.1") }}
# ARG RENKU_VERSION={{ __renku_version__ | default("2.9.1") }}

# For local build
# ARG RENKU_VERSION="2.9.1"
ARG RENKU_VERSION="2.9.1"

########################################################
# Do not edit this section and do not add anything below
Expand Down
6 changes: 1 addition & 5 deletions aiida/environment.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
name: "base"
channels:
- conda-forge
- cjs14
dependencies:
# - aiida-core
- aiida-core.services
# while aiida-core.services requires rabbitmq-server>=3.7, for some reason version 3.6.15 is installed without the line below
# - rabbitmq-server>=3.8
- aiida-core.services=2.2.2
prefix: "/opt/conda"
5 changes: 3 additions & 2 deletions aiida/post-init.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ aiida_profile="aiida_renku"
institution="RenkuLab"

project_dir="$(pwd)"
repo_dir="${project_dir}/repo"
repo_dir="${project_dir}/aiida_data"
mkdir "$repo_dir"
echo "$repo_dir" >> .gitignore

# Export AIIDA_PATH environment variable
export AIIDA_PATH=$repo_dir
Expand Down Expand Up @@ -60,5 +61,5 @@ verdi profile setup core.sqlite_dos \
{% endif %}

verdi config set warnings.rabbitmq_version False
echo "consumer_timeout = 36000000000" > /opt/conda/pkgs/rabbitmq-server-3.12.12-ha770c72_0/etc/rabbitmq/rabbitmq.conf
echo "consumer_timeout = 36000000000" > /opt/conda/pkgs/rabbitmq-server-3.13.1-ha770c72_0/etc/rabbitmq/rabbitmq.conf
rabbitmq-server -detached
1 change: 0 additions & 1 deletion aiida/requirements.txt

This file was deleted.

0 comments on commit c94a469

Please sign in to comment.