Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Date.isBetween #289

Merged
merged 1 commit into from
Oct 22, 2017
Merged

Add test for Date.isBetween #289

merged 1 commit into from
Oct 22, 2017

Conversation

kaphacius
Copy link
Member

Added a missing test for Date.isBetween extension method

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 4.
  • New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.

@SwifterSwiftBot
Copy link

1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Oct 20, 2017

Codecov Report

Merging #289 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   94.41%   94.51%   +0.09%     
==========================================
  Files          99       99              
  Lines        5494     5503       +9     
==========================================
+ Hits         5187     5201      +14     
+ Misses        307      302       -5
Flag Coverage Δ
#ios 94.3% <100%> (+0.1%) ⬆️
#osx 60.82% <100%> (+0.15%) ⬆️
#tvos 89.22% <100%> (+0.11%) ⬆️
Impacted Files Coverage Δ
Tests/FoundationTests/DateExtensionsTests.swift 94.79% <100%> (+0.08%) ⬆️
Sources/Extensions/Foundation/DateExtensions.swift 100% <0%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c67b5d...84b2722. Read the comment docs.

@omaralbeik omaralbeik merged commit 55a4603 into SwifterSwift:master Oct 22, 2017
@omaralbeik
Copy link
Member

Thanks @kaphacius 👍

@kaphacius kaphacius deleted the Test_for_Date_inBetween branch October 22, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants