Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isWithin method to Date extensions #288

Closed
wants to merge 0 commits into from
Closed

Add isWithin method to Date extensions #288

wants to merge 0 commits into from

Conversation

kaphacius
Copy link
Member

@kaphacius kaphacius commented Oct 20, 2017

another go on #258

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 4.
  • New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.

@SwifterSwiftBot
Copy link

SwifterSwiftBot commented Oct 20, 2017

2 Warnings
⚠️ Consider adding tests for new extensions or updating existing tests for a modified SwifterSwift extension
⚠️ The source files have been modified. Please consider adding a CHANGELOG entry if necessary.
1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Oct 20, 2017

Codecov Report

Merging #288 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   94.51%   94.43%   -0.08%     
==========================================
  Files          99       99              
  Lines        5503     5520      +17     
==========================================
+ Hits         5201     5213      +12     
- Misses        302      307       +5
Flag Coverage Δ
#ios 94.23% <100%> (-0.08%) ⬇️
#osx 60.85% <100%> (+0.03%) ⬆️
#tvos 89.16% <100%> (-0.06%) ⬇️
Impacted Files Coverage Δ
Tests/FoundationTests/DateExtensionsTests.swift 94.89% <100%> (+0.1%) ⬆️
Sources/Extensions/Foundation/DateExtensions.swift 98.31% <100%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a338f27...7a580b8. Read the comment docs.

@kaphacius
Copy link
Member Author

what happened? how did you push into my master? :)
not sure why the build fails now

@kaphacius kaphacius closed this Oct 22, 2017
@omaralbeik
Copy link
Member

@kaphacius Sorry It looks like your #289 PR, had a conflict with this PR, I fixed it manually from here which added a commit to your master.
Could you please check and open the request again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants