feat: add JSON support to windows sources #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
changed the title
sumo-drosiek
changed the title
sumo-drosiek
commented
May 6, 2022
sumo-drosiek
commented
May 6, 2022
Signed-off-by: Dominik Rosiek <[email protected]>
added 2 commits
May 6, 2022 14:17
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
andrzej-stencel
approved these changes
May 10, 2022
sumo-drosiek
commented
May 10, 2022
sumo-drosiek
commented
May 10, 2022
test/integration/source-resource/serverspec/local_win_event_log_create_spec.rb
Outdated
Show resolved
Hide resolved
sumo-drosiek
commented
May 10, 2022
test/integration/source-resource/serverspec/remote_win_event_log_create_spec.rb
Outdated
Show resolved
Hide resolved
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
This was referenced May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
General
Remove any versioning you did yourself if applicable
Update Changelog following the conventions laid out on Keep A Changelog with all new changes under
## [Unreleased]and using a### Added, Fixed, Changed, or Breaking Changesub-header.Update README with any necessary changes
RuboCop passes
Foodcritic passes
Existing tests pass
Purpose
Known Compatibility Issues