Feature/windows json format #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Resolves open issue that there is no windows JSON support in windows events source. Closes #187
General
Remove any versioning you did yourself if applicable
Update Changelog following the conventions laid out on Keep A Changelog with all new changes under
## [Unreleased]and using a### Added, Fixed, Changed, or Breaking Changesub-header.Update README with any necessary changes
RuboCop passes
Foodcritic passes
Existing tests pass
Purpose
The chef cookbook only has support for legacy windows format. This PR adds four new optional attributes to JSON source provider to support customers wanting to collect windows JSON format instead of legacy format.
Known Compatibility Issues
Should be none since there is no change to existing sources as the new attributes on the source are optional. It's worth considering at some point whether JSON format with 1 for eventMessage should be the default for the cookbook since the recommended default for new agent deployments, especially for customers using Cloud SIEM Enterprise.