Check SMS is enabled before showing texting opts #803
Conversation
* `is_sms_enabled()`, sees if the `twilio` config in the settings are non-empty (doesn't check that they work) * Turns off mentions of texting in the "Share" page * Turns off option to get texts from the reminder system * Turns off options to text the link to yourself when signing
| @@ -311,7 +317,7 @@ template: al_share_answers_message_template | |||
| subject: | | |||
| ${ AL_ORGANIZATION_TITLE } form from ${ al_share_form_from_name } | |||
| content: | | |||
| ${ share_interview_answers_message } | |||
| ${ share_interview_answers_message.replace("\n", "<br>") } | |||
There was a problem hiding this comment.
Are we always sending HTML email?
There was a problem hiding this comment.
Yeah, docassemble always sends an HTML version. Relevant code is: https://github.com/jhpyle/docassemble/blob/70d7dbfd7db5075f1e51d2b64906739a8f86f679/docassemble_base/docassemble/base/util.py#L8366-L8371
Specifically, when you pass in a template, it gets the content of that template in HTML. BeautifulSoup strips out the tags for the plaintext version if the client doesn't support HTML (which most email clients support, and default to), but both the HTML and non-HTML version are provided in the Message variable. Haven't gone further, but we can't know which clients will and won't be using HTML.
I'm fine with changing it, but from what I understand, |
is_sms_enabled(), sees if thetwilioconfig in the settings are non-empty (doesn't check that they work)The only change I could see being suggested is to move
is_sms_enabled()(andis_phone_or_email(), even thought it's been in AL for a while) to the Toolbox. IMO, it's not worth splitting highly coupled functions between two different packages, but will happily do it if suggested.Fixes #411 for texting, not for email, but as mentioned in the meeting this morning, most of our users have some sort of email enabled on their server.