-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some features (signature, sharing) that depend on multi_user responsive to whether it's turned on or off #411
Comments
I've made some progress on hiding SMS specific options downstream in MLH on just the Share page, trying to get it upstream now. The places where I see we offer SMS sending that I've address in my branch: I'm gonna focus on just those at the moment, since the email stuff seems to be in more places and more critical to running a DA server (with password resets, etc.) |
Reopening, as I didn't cover things that have
|
I think we'll want to go with your first idea, turn sharing off entirely when For signature to your phone, it would still work if the user is logged in, it's just a pain to use in that scenario. |
I think we might want some Python functions to check for a valid SMS and email configuration.
I think we'll need to audit the default interview text to look for places we offer the ability to send by email or SMS and conditionally turn those off. In most places we allow both methods, and in some there's a backup method of clicking a link to copy text, so we probably don't want to turn these totally off in the footer.
The text was updated successfully, but these errors were encountered: