Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some features (signature, sharing) that depend on multi_user responsive to whether it's turned on or off #411

Open
nonprofittechy opened this issue Feb 25, 2022 · 3 comments · Fixed by #803

Comments

@nonprofittechy
Copy link
Member

nonprofittechy commented Feb 25, 2022

I think we might want some Python functions to check for a valid SMS and email configuration.

I think we'll need to audit the default interview text to look for places we offer the ability to send by email or SMS and conditionally turn those off. In most places we allow both methods, and in some there's a backup method of clicking a link to copy text, so we probably don't want to turn these totally off in the footer.

@nonprofittechy nonprofittechy added the enhancement New feature or request label Feb 25, 2022
@nonprofittechy nonprofittechy changed the title Make some features (signature, sharing) that depend on multi_user responsive to whether it's turned on or off Make some features (signature, sharing) that depend on multi_user or a valid email/sms config responsive to whether it's turned on or off Aug 22, 2023
@BryceStevenWilley
Copy link
Contributor

BryceStevenWilley commented Dec 10, 2023

I've made some progress on hiding SMS specific options downstream in MLH on just the Share page, trying to get it upstream now.

The places where I see we offer SMS sending that I've address in my branch:

I'm gonna focus on just those at the moment, since the email stuff seems to be in more places and more critical to running a DA server (with password resets, etc.)

@BryceStevenWilley
Copy link
Contributor

Reopening, as I didn't cover things that have multi_user = False yet. I feel like there are a few approaches we could take to those interviews:

  • turn things off entirely
  • give users the ability to manually turn it on and off
  • automatically turn it on when some one shares the signature screen, and turns it off once the form is signed (or some other type of control)

@BryceStevenWilley BryceStevenWilley changed the title Make some features (signature, sharing) that depend on multi_user or a valid email/sms config responsive to whether it's turned on or off Make some features (signature, sharing) that depend on multi_user responsive to whether it's turned on or off Dec 12, 2023
@nonprofittechy
Copy link
Member Author

Reopening, as I didn't cover things that have multi_user = False yet. I feel like there are a few approaches we could take to those interviews:

* turn things off entirely

* give users the ability to manually turn it on and off

* automatically turn it on when some one shares the signature screen, and turns it off once the form is signed (or some other type of control)

I think we'll want to go with your first idea, turn sharing off entirely when multi_user=False. This is because it will usually only be the case when the author has to follow some data privacy liability standard, such as storing PII like a social security number or bank account number. Likely they'll have their data controls in a written policy that they have to maintain and certify that they're following. Making it up to the user to turn off doesn't sound like a good idea.

For signature to your phone, it would still work if the user is logged in, it's just a pain to use in that scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants