feat: update cp failed task key #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergebouchut2
requested review from
HamdyD,
jmorel,
Milouu and
alexisdeh
as code owners
sergebouchut2
changed the title
sergebouchut2
force-pushed
the
feat/remove_failed_task_category
branch
from
30e8ba8 to
eb1d757
Compare
sergebouchut2
changed the title
2 tasks
jmorel
approved these changes
Oct 7, 2022
CHANGELOG.md
Outdated
| @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Open task drawer directly in cp details page (#122) | |||
| - Algo creation events aren't included in newsfeed anymore (#127) | |||
| - Renamed any tuple thing into a task thing (#129) | |||
| - Update compute plan failed task key | |||
There was a problem hiding this comment.
Could you include the PR number here?
jmorel
approved these changes
Oct 7, 2022
Signed-off-by: Serge Bouchut <[email protected]>
Signed-off-by: Serge Bouchut <[email protected]>
Signed-off-by: Milouu <[email protected]>
Milouu
force-pushed
the
feat/remove_failed_task_category
branch
from
23ad981 to
248ff37
Compare
Milouu
requested review from
ThibaultFy,
oleobal and
guilhem-barthes
as code owners
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Serge Bouchut [email protected]
API has changed: we now have a flat field
failed_task_key(asfailed_task.categoryhas been removed).See: Substra/substra-backend#525
Linked to this [ASANA TASK](link here)
Description
How to test
Screenshots
Notes for developers and reviewers: