-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove failed task category from compute plan API response #525
Conversation
/e2e --refs substra=feat/remove_failed_task_category,substra-backend=feat/remove_failed_task_category --tests sdk,substrafl |
End to end tests: ✔️ SUCCESS “To infinity and beyond!” ― Buzz Lightyear, Toy Story |
03f698b
to
8435791
Compare
/e2e --refs substra=feat/remove_failed_task_category,substra-backend=feat/remove_failed_task_category --tests sdk,substrafl |
End to end tests: ✔️ SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guilhem-barthes shouldn't we also remove failed_task_category
from the ComputePlan model ?
/e2e --help |
|
dc34d97
to
488a2e6
Compare
Signed-off-by: Serge Bouchut <[email protected]>
Signed-off-by: Milouu <[email protected]>
488a2e6
to
1e3d5f0
Compare
Signed-off-by: Milouu <[email protected]>
a355e70
to
01c4607
Compare
Signed-off-by: Milouu <[email protected]>
Signed-off-by: Serge Bouchut [email protected]
Description
Remove failed task category deprecated field from the compute plan API response in order to easily remove category field in the backend later.
See also:
How has this been tested?
Checklist