Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove failed task category from compute plan API response #525

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

sergebouchut2
Copy link
Contributor

@sergebouchut2 sergebouchut2 commented Oct 7, 2022

Signed-off-by: Serge Bouchut [email protected]

Description

Remove failed task category deprecated field from the compute plan API response in order to easily remove category field in the backend later.
See also:

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@github-actions github-actions bot added the api label Oct 7, 2022
@sergebouchut2
Copy link
Contributor Author

/e2e --refs substra=feat/remove_failed_task_category,substra-backend=feat/remove_failed_task_category --tests sdk,substrafl

@Owlfred
Copy link

Owlfred commented Oct 7, 2022

End to end tests: ✔️ SUCCESS

“To infinity and beyond!” ― Buzz Lightyear, Toy Story

@ThibaultFy
Copy link
Member

/e2e --refs substra=feat/remove_failed_task_category,substra-backend=feat/remove_failed_task_category --tests sdk,substrafl

@Owlfred
Copy link

Owlfred commented Jan 17, 2023

End to end tests: ✔️ SUCCESS

Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guilhem-barthes shouldn't we also remove failed_task_category from the ComputePlan model ?

@ThibaultFy
Copy link
Member

/e2e --help

@Owlfred
Copy link

Owlfred commented Jan 17, 2023

Usage: /e2e [options] [help]

/e2e may appear anywhere as long as it is on its own line

Options:
  --refs <value>                                         Extra refs (branch or tag) with format REPO=GIT_REF,REPO=GIT_REF.
  Supported repositories: substra-hlf-k8s, orchestrator, substra-backend, substra-frontend, substra-tools, substrafl, substra, substra-tests, substra-ci.
  Example: /e2e --refs substra-backend=some_branch,orchestrator=some_tag (default: {})
  --tests-to-run, --tests <tests-to-run>                 Comma-separated list of tests to run. Valid options: sdk,substrafl,frontend or NONE. (default: "sdk")
  --benchmarks-to-run, --benchmarks <benchmarks-to-run>  Comma-separated list of workflows tests to run. Valid options: mnist, camelyon or NONE. (default: "NONE")
  --orchestrator-mode, --mode <orchestrator-mode>        Comma-separated list of orchestrator modes to run tests for. Valid options: standalone,distributed (default: "standalone,distributed")
  -h, --help                                             display help for command

@Milouu Milouu force-pushed the feat/remove_failed_task_category branch from dc34d97 to 488a2e6 Compare January 18, 2023 15:26
@Milouu Milouu force-pushed the feat/remove_failed_task_category branch from 488a2e6 to 1e3d5f0 Compare January 18, 2023 16:03
Signed-off-by: Milouu <[email protected]>
@Milouu Milouu force-pushed the feat/remove_failed_task_category branch from a355e70 to 01c4607 Compare January 18, 2023 16:40
@Milouu Milouu merged commit 637311c into main Jan 20, 2023
@Milouu Milouu deleted the feat/remove_failed_task_category branch January 20, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants