Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ...from_valor_dict methods #786

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Remove ...from_valor_dict methods #786

merged 7 commits into from
Oct 9, 2024

Conversation

ntlind
Copy link
Contributor

@ntlind ntlind commented Oct 9, 2024

Improvements

  • Update benchmark scripts to no longer need the ...from_valor_dict methods
  • Remove ...from_valor_dict methods
  • Fix small typing error

@ntlind ntlind requested review from czaloom and ekorman as code owners October 9, 2024 18:03
@ntlind ntlind merged commit f56677d into main Oct 9, 2024
16 checks passed
@ntlind ntlind deleted the remove_from_valor_dict branch October 9, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czaloom czaloom czaloom approved these changes

@ekorman ekorman Awaiting requested review from ekorman ekorman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntlind @czaloom