Prepare Lite for Core Migration #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntlind
reviewed
Oct 9, 2024
lite/benchmarks/benchmark_objdet.py
Outdated
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| import requests | |||
| from tqdm import tqdm | |||
| from valor_lite.detection import DataLoader, MetricType | |||
| from valor_lite.cv.detection import DataLoader, MetricType | |||
There was a problem hiding this comment.
the "CV" bucket doesn't feel MECE: if the user does pip install valor-<name>[cv] (from your example yesterday), they'd expect classification to be installed too. why not leave classification, detection, and segmentation as-is (i.e., not grouping them under CV), but group the LLM metrics separately under NLP?
There was a problem hiding this comment.
Polling for feedback on flattening the import structure!
As for the custom installs, I feel thats something we can deal with at a later point.
ntlind
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
detectiontoobject_detectionsegmentationtosemantic_segmentation