Fix crossspectrum all default #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 43 43
Lines 7918 7918
=======================================
Hits 7704 7704
Misses 214 214
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
matteobachetti
force-pushed
the
fix_crossspectrum_all_default
branch
from
f5c0862
to
5324211
Compare
mgullik
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Hi @matteobachetti,
this is a good catch.
Only one thing, you swapped the order of the two lightcurves in Crossspectrum tests, why?
|
They were set up before our change if convention, and we didn't realize it was a mistake because the test was wrong (the cross spectrum was real-valued) 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, in
Crossspectrumthe power type remained "real", which also meant that, by default, the lags measured byCrossspectrumwere all wrong.