Exposed volume prop in HowlOptions #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefH
requested changes
May 31, 2021
| @@ -19,6 +19,14 @@ | |||
| <td><button class="btn btn-primary oi oi-media-play" @onclick="Play3"></button></td> | |||
| <td>Play an audio file with source location and format</td> | |||
| </tr> | |||
| <tr> | |||
| <td><button class="btn btn-primary oi oi-media-play" @onclick="PlayHalf"></button></td> | |||
There was a problem hiding this comment.
Can you rename PlayHalf to PlayAudioWithHalfVolume in all code?
| <td>Play an audio file with source location, format and volume set to half</td> | ||
| </tr> | ||
| <tr> | ||
| <td><button class="btn btn-primary oi oi-media-play" @onclick="PlayQuoter"></button></td> |
There was a problem hiding this comment.
Can you rename PlayQuoter to PlayAudioWithQuarterVolume in all code?
StefH
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17,
Added Volume property to HowlOptions and added Play half and 1/4 buttons to sample apps.