Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support volume property #17

Closed
k-u-s opened this issue May 31, 2021 · 2 comments · Fixed by #18
Closed

Support volume property #17

k-u-s opened this issue May 31, 2021 · 2 comments · Fixed by #18
Labels
enhancement New feature or request

Comments

@k-u-s
Copy link
Contributor

k-u-s commented May 31, 2021

I would like to propose exposing
https://github.com/goldfire/howler.js#volume-number-10
in
src/Howler.Blazor/Components/HowlOptions.cs
as double? in order to have better control on how multiple sounds are played.
@k-u-s k-u-s mentioned this issue May 31, 2021
Merged
@StefH StefH closed this as completed in #18 Jun 1, 2021
@StefH StefH added the enhancement New feature or request label Jun 1, 2021
@grierson
Copy link

Is possible to update the volume once it's playing?

public ValueTask Volume(int soundId, double volume) { return _runtime.InvokeVoidAsync("howl.volume", soundId, volume); }

@StefH
Copy link
Owner

StefH commented Jun 14, 2021

@grierson
This can be added.

And also there should be a global / static Volume set option, which sets the volume for all sounds.

// Change global volume.
Howler.volume(0.5);

Can you create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exposed volume prop in HowlOptions k-u-s/Howler.Blazor
3 participants
@StefH @grierson @k-u-s