Proxy support for WebSocket connections

[ezhevita]

Adds proxy support for WebSocket connections

[JustArchi]

You most likely want to also make it possible to supply IWebProxy to SteamConfiguration so this can be used without manual connections.

[codecov-io]

Codecov Report

Merging #717 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   22.63%   22.62%   -0.01%     
==========================================
  Files          93       93              
  Lines        9568     9572       +4     
  Branches      795      796       +1     
==========================================
  Hits         2166     2166              
- Misses       7270     7274       +4     
  Partials      132      132

Impacted Files	Coverage Δ
...t2/SteamKit2/Networking/Steam3/WebSocketContext.cs	0% <0%> (ø)	⬆️
...SteamKit2/Networking/Steam3/WebSocketConnection.cs	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38dd2fd...108966c. Read the comment docs.

[JustArchi]

Solve merge conflicts and LGTM.

[yaakov-h]

#587 (comment)

[JustArchi]

Enabling access to "our" Steam for users in China would be one compelling use case for this. This is in regards to recent events there.

[yaakov-h]

If Steam global gets blocked by China, an itty bitty SOCKS proxy is probably not going to hold up against the GFW. You would need a lower-level VPN.

Regardless, any solution which works for Steam today or in future would also work for a SteamKit2-based codebase, unless Steam itself adds proxy support.

[MakcStudio]

I do not really understand, you did not add a ready-made solution for proxy support to the master branch? If I want to use this solution, do I need to compile my own version of the library?

[ezhevita]

@MakcStudio Yes, this PR wasn't accepted, so you have to compile this branch manually.

[fjch1997]

If Steam global gets blocked by China, an itty bitty SOCKS proxy is probably not going to hold up against the GFW. You would need a lower-level VPN.

Regardless, any solution which works for Steam today or in future would also work for a SteamKit2-based codebase, unless Steam itself adds proxy support.

Many people in China are using Shadowsocks which encrypts SOCKS5 traffic between the client and server. Also, WebSocket proxy goes throughh HTTPS and would be encrypted as well. The GFW has no way of seeing that it is trying to access Steam

This is useful and quite a simple update. I am not sure why it can't be merged.

[fazelukario]

@yaakov-h As @fjch1997 mentioned, it makes sense to add a proxy, and I think that to ignore such a possibility (given that this feature is optional) in a library that is designed for software solutions such as bots, etc. at least wrong, and at most egoistically and stupidly.

[yaakov-h]

We're not ignoring it, we're selective about adding features that can be easily misused for harmful and abusive purposes. If you have a compelling, legitimate, and practical use-case, then I'm all ears. If something is theoretically useful only in future, but practically abusable now, then I'll wait for that future.