Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP stage-main-Juneteenth (6.19) -pre #1623

Merged
merged 181 commits into from
Jun 23, 2020
Merged

WIP stage-main-Juneteenth (6.19) -pre #1623

merged 181 commits into from
Jun 23, 2020

Conversation

schuyler1d
Copy link
Collaborator

@schuyler1d schuyler1d commented Jun 13, 2020

Draft Release Notes

  • Spoke 7.0 has several valuable infrastructure updates
    • Backwards incompatibilities:
      • This change has schema changes on the campaign table which you should make sure to update -- it should be a fast and painless upgrade (automatic if you have it setup). See the deploy steps section for details of how to migrate.
      • The Texter UI Accessibility improvements DO come at the expense of changing how the Enter key behaves for texters. You should communicate this to your texting team and update and training materials. (to revert this functionality, you can enable the env var HOLD_ENTER_KEY)
      • SuperVolunteer roles now have access to all MessageReview operations
    • Improvements
      • There is now further support for VAN -- a robust action handler that can be enabled by adding ACTION_HANDLERS=ngpvan-action to your environment variables will enable this.

      • We have a new framework for extending the Texter UI interface called "sideboxes". Enabled with environment variable TEXTER_SIDEBOXES which works similarly to action handlers, where it should be a comma separated list of enabled sideboxes. Developers can add sidebox functionality, and admins can set defaults in the organization Settings section and changes per-campaign -- enabling/disabling sideboxes. Two so-far are:

        • contact-reference which is a link the texter can click and/or share with an admin for direct access to that conversation later
        • tag-contact which if you have EXPERIMENTAL_TAGS=1 enabled and create tags, a texter will have an interface to mark them. They can then be filtered for in Message Review.

        There will be more work here going forward -- feedback is welcome as this is still a feature in active development.

      • There is another experimental new framework: Message Handlers which can intercept a message pre and post-save with a sample message handler that can tag profanity -- you can experiment with this by setting MESSAGE_HANDLERS=profanity-tagger

      • Texter UI Accessibility improvements -- previously we captured the Enter key to send a message. This was inaccessible because the Enter key is used when navigating with the keyboard in order to 'click' a button. Sending is now possible with Ctrl-x (and skip is Ctrl-y).

      • We have now disabled by default the ability to hold down the Enter key -- for sending you can now press any letter key (or Enter) to send a message. If you want this functionality back set HOLD_ENTER_KEY=1

      • There is now a campaign 'sending errors' report which summarizes how many sending errors have been reported by Twilio. Carrier Violation error messages are especially useful (and important) to track.

      • A new contact-loader that allows upload into S3 to make larger uploads possible if you have deployed on AWS.

    • Bug fixes -- there are too many bug fixes to mention -- please see the full list of linked changes
    • Deploy Steps:
      Instructions for migrating you database
      Make sure SUPPRESS_MIGRATIONS="" (not 0!) in your environment
      If you're using AWS Lambda, check out the deploy instructions here

Thanks to all the contributors part of this release including: @ibrand @lperson @matteosb @schuyler1d -- Also special shout outs to Working Families Party and Movement For Black Lives for staging some of these changes and giving feedback (along with MoveOn, too) -- Thank you to the Spoke teams there that drove great campaigns while providing technical bug reports so we could make this a better release ❤️

Our next release, we're expecting some more great features -- ability to suspend texters, improving the dynamic assignment workflow, and more improvements around tags. Devs and orgs, please send your PRs in now, so we can test your work out and get it in the next release.

schuyler1d and others added 30 commits May 11, 2020 17:10
…gn join urls, 3. move dynamic assignment into a separate campaign admin panel
… campaign join links with organization join links -- this allows some security contours that the default behavior does not.
Purpose: to easily save lookup results for contactTypeId and
inputTypeId. They will be refreshed when the cache expires. This also
abstracts special handling for different types of updates from
processAction.
…ions' into campaign-jointoken-schemaprep-apolloupgrade
todo: 1. admin controls 2. hiding sidebox popover when bigger screen
@schuyler1d schuyler1d mentioned this pull request Jun 16, 2020
@schuyler1d schuyler1d changed the title WIP ondeck stage-main-7.1-pre WIP ondeck stage-main-7.0-pre Jun 16, 2020
@schuyler1d schuyler1d changed the title WIP ondeck stage-main-7.0-pre WIP stage-main-7.0-pre Jun 16, 2020
@schuyler1d schuyler1d changed the title WIP stage-main-7.0-pre WIP stage-main-Juneteenth (6.19) -pre Jun 16, 2020
@ibrand ibrand self-requested a review June 23, 2020 22:24
ibrand
ibrand previously approved these changes Jun 23, 2020
@schuyler1d schuyler1d requested a review from ibrand June 23, 2020 22:50
@schuyler1d schuyler1d merged commit c13bc44 into main Jun 23, 2020
@schuyler1d schuyler1d deleted the stage-main-71 branch June 23, 2020 22:59
@lperson lperson self-requested a review June 23, 2020 22:59
@github-pages github-pages bot temporarily deployed to github-pages July 2, 2020 00:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants