Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage-main 7.0 prep #1599

Closed
wants to merge 182 commits into from
Closed

Stage-main 7.0 prep #1599

wants to merge 182 commits into from

Conversation

schuyler1d
Copy link
Collaborator

@schuyler1d schuyler1d commented Jun 9, 2020

  • texter sideboxes (behind TEXTER_SIDEBOXES) (schuyler1d)
  • Tag improvements (behind EXPERIMENTAL_TAGS) (schuyler1d)
    • texter sidebox for tagging
    • Tag filtering in Message Review
  • VAN action handler (lperson)
  • Conversation links (as a sidebox and in Message Review) (lperson)
  • https://github.com/MoveOnOrg/Spoke/pull/1602 Make dataloaders per-request (matteosb)
    • New dev rule: no loaders in mutations -- only use cacheableData
  • Some accessibility tweaks for the Texter Experience; Different keyboard shortcuts to send:
    • Enter key is removed to send for accessibility reasons (needs to be used for keyboard 'click'ing)
    • Ctrl-x to Send Ctrl-y to Skip, When you are sending initial texts, pressing any key will send.
  • https://github.com/MoveOnOrg/Spoke/pull/1604 remove buggy notification on replies (matteosb)

Awaiting completion

Draft Release Notes

  • Spoke 7.0 has several valuable infrastructure updates
    • Bug fixes:
      • Twilio incoming message handlers would sometimes fail due to a defunct database (knex) listener
      • Local memory cache would sometimes be used after updates, especially in persisting multi-server environments (tech: 'loaders' are now appropriately per-request and only used in queries, not mutations)
    • Improvements
      • There is now further support for VAN -- a robust action handler that can be enabled by adding ACTION_HANDLERS=ngpvan-action to your environment variables will enable this.

      • We have a new framework for extending the Texter UI interface called "sideboxes". Enabled with environment variable TEXTER_SIDEBOXES which works similarly to action handlers, where it should be a comma separated list of enabled sideboxes. Developers can add sidebox functionality, and admins can set defaults in the organization Settings section and changes per-campaign -- enabling/disabling sideboxes. Two so-far are:

        • contact-reference which is a link the texter can click and/or share with an admin for direct access to that conversation later
        • tag-contact which if you have EXPERIMENTAL_TAGS=1 enabled and create tags, a texter will have an interface to mark them. They can then be filtered for in Message Review.

        There will be more work here going forward -- feedback is welcome as this is still a feature in active development.

      • Texter UI Accessibility improvements -- previously we captured the Enter key to send a message. This was inaccessible because the Enter key is used when navigating with the keyboard in order to 'click' a button. Sending is now possible with Ctrl-x (and skip is Ctrl-y).

      • We have now disabled by default the ability to hold down the Enter key -- for sending you can now press any letter key (or Enter) to send a message. If you want this functionality back set HOLD_ENTER_KEY=1

    • Backwards incompatibilities:
      • This change has schema changes on the campaign table which you should make sure to update -- it should be a fast and painless upgrade (automatic if you have it setup)
      • The Texter UI Accessibility improvements DO come at the expense of changing how the Enter key behaves for texters. You should communicate this to your texting team and update and training materials.

lperson and others added 30 commits May 8, 2020 13:52
…gn join urls, 3. move dynamic assignment into a separate campaign admin panel
@schuyler1d schuyler1d added S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc and removed S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage labels Jun 11, 2020
@lperson lperson temporarily deployed to spoke-wf-mo June 12, 2020 17:32 Inactive
* Display error from last import attempt, if any
* Fix bug that caused import button to forever be disabled for a
  campaign after a failed import
* Delete old jobs of type `import_script` for the campaign before
  starting a new script import
…editor

fix unwanted pop ups when loading script editor ON SAFARI
@joemcl joemcl temporarily deployed to spoke-wf-mo June 13, 2020 04:15 Inactive
@joemcl joemcl temporarily deployed to spoke-wf-mo June 14, 2020 04:32 Inactive
@schuyler1d
Copy link
Collaborator Author

closing in favor of https://github.com/MoveOnOrg/Spoke/pull/1623 as a Spoke 7.0 target

@schuyler1d schuyler1d closed this Jun 16, 2020
@schuyler1d schuyler1d deleted the stage-main-62 branch June 23, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants