-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage-main 7.0 prep #1599
Closed
Closed
Stage-main 7.0 prep #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gn join urls, 3. move dynamic assignment into a separate campaign admin panel
…lp_1512_home_stretch
…es-62' into stage-main
…Roles-62 Fix editOrganizationRoles
schuyler1d
added
S-ready for stage-main (qa)
Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
and removed
S-on deck
Status (ADMINS ONLY): PR label for those that will be added to the next stage
labels
Jun 11, 2020
require contact response before exposing the message review view
* Display error from last import attempt, if any * Fix bug that caused import button to forever be disabled for a campaign after a failed import * Delete old jobs of type `import_script` for the campaign before starting a new script import
Minor changes to fix script import ui
…editor fix unwanted pop ups when loading script editor ON SAFARI
…editor If a contact has no timezone, format local time using campaign's timezone.
Use a default timezone moment understands when running on Lambda
…ur-enforcement Fix cacheableData queries in texting hour mutations
Use DST_REFERENCE_TIMEZONE for campaigns that don't have a timezone
closing in favor of https://github.com/MoveOnOrg/Spoke/pull/1623 as a Spoke 7.0 target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-ready for stage-main (qa)
Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loaders
in mutations -- only use cacheableDataAwaiting completion
Draft Release Notes
There is now further support for VAN -- a robust action handler that can be enabled by adding
ACTION_HANDLERS=ngpvan-action
to your environment variables will enable this.We have a new framework for extending the Texter UI interface called "sideboxes". Enabled with environment variable TEXTER_SIDEBOXES which works similarly to action handlers, where it should be a comma separated list of enabled sideboxes. Developers can add sidebox functionality, and admins can set defaults in the organization Settings section and changes per-campaign -- enabling/disabling sideboxes. Two so-far are:
contact-reference
which is a link the texter can click and/or share with an admin for direct access to that conversation latertag-contact
which if you have EXPERIMENTAL_TAGS=1 enabled and create tags, a texter will have an interface to mark them. They can then be filtered for in Message Review.There will be more work here going forward -- feedback is welcome as this is still a feature in active development.
Texter UI Accessibility improvements -- previously we captured the Enter key to send a message. This was inaccessible because the Enter key is used when navigating with the keyboard in order to 'click' a button. Sending is now possible with
Ctrl-x
(and skip isCtrl-y
).We have now disabled by default the ability to hold down the Enter key -- for sending you can now press any letter key (or Enter) to send a message. If you want this functionality back set HOLD_ENTER_KEY=1
campaign
table which you should make sure to update -- it should be a fast and painless upgrade (automatic if you have it setup)