Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releaseContacts endpoint and campaign cached counts improvements #1613

Closed
wants to merge 2 commits into from
Closed

releaseContacts endpoint and campaign cached counts improvements #1613

wants to merge 2 commits into from

Conversation

schuyler1d
Copy link
Collaborator

A part of https://github.com/MoveOnOrg/Spoke/issues/1533

  • Also supports campaign stat counts on "regular" redis without REDIS_CONTACT_CACHE enabled
  • Also adds testing for "regular" redis without contact cache'

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • [na] If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • [na] I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@schuyler1d
releaseContacts endpoint and track campaign needsResponseCount
2523cb8 
Also supports campaign stat counts on "regular" redis without REDIS_CONTACT_CACHE enabled
Also adds testing for "regular" redis without contact cache
@schuyler1d schuyler1d added the S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage label Jun 11, 2020
@schuyler1d schuyler1d mentioned this pull request Jun 16, 2020
Merged
@schuyler1d schuyler1d added S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc and removed S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage labels Jun 18, 2020
@ibrand ibrand requested a review from lperson June 22, 2020 15:53
@schuyler1d schuyler1d closed this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lperson lperson Awaiting requested review from lperson

Assignees
No one assigned
Labels
S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schuyler1d