[BugFix] fix lock release issue in cloud native pk table (backport #53878) #53884
+54
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When
prepare_primary_index
, PK index load will fail and remove this index from cache:But
PrimaryKeyTxnLogApplier
still hold the lock guard. AfterPrimaryKeyTxnLogApplier
been destroyed, lock guard will release the lock which address is invalid because PK index already been remove.This will cause invalid address access, it lead to unexpected behavior like stucking at here:
What I'm doing:
If PK index load fail, we need to release the lock before PK index been removed.
This pull request includes changes to improve error handling in the
UpdateManager
class and adds a new test case to cover index load failures. The most important changes include releasing the lock guard before removing the index entry when load or prepare operations fail, and adding a new test case inLakePrimaryKeyPublishTest
.Improvements to error handling:
be/src/storage/lake/update_manager.cpp
: Added code to release the lock guard before removing the index entry if the load operation fails inprepare_primary_index
.be/src/storage/lake/update_manager.cpp
: Added code to release the lock guard before removing the index entry if the prepare operation fails inprepare_primary_index
.New test case:
be/test/storage/lake/primary_key_publish_test.cpp
: Added a new test casetest_index_load_failure
toLakePrimaryKeyPublishTest
to verify the behavior when index load fails.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: