[BugFix] fix lock release issue in cloud native pk table

[luohaha]

Why I'm doing:

When prepare_primary_index, PK index load will fail and remove this index from cache:

StatusOr<IndexEntry*> UpdateManager::prepare_primary_index(
        const TabletMetadataPtr& metadata, MetaFileBuilder* builder, int64_t base_version, int64_t new_version,
        std::unique_ptr<std::lock_guard<std::shared_timed_mutex>>& guard) {
    ......
    // Fetch lock guard before `lake_load`
    guard = index.fetch_guard(); <---- get lock guard
    Status st = index.lake_load(_tablet_mgr, metadata, base_version, builder);
    ...
    if (!st.ok()) {
        .....
        _index_cache.remove(index_entry); <---- remove index
        ....
        return Status::InternalError(msg);
    }

But PrimaryKeyTxnLogApplier still hold the lock guard. After PrimaryKeyTxnLogApplier been destroyed, lock guard will release the lock which address is invalid because PK index already been remove.

This will cause invalid address access, it lead to unexpected behavior like stucking at here:

What I'm doing:

If PK index load fail, we need to release the lock before PK index been removed.

This pull request includes changes to improve error handling in the UpdateManager class and adds a new test case to cover index load failures. The most important changes include releasing the lock guard before removing the index entry when load or prepare operations fail, and adding a new test case in LakePrimaryKeyPublishTest.

Improvements to error handling:

• be/src/storage/lake/update_manager.cpp: Added code to release the lock guard before removing the index entry if the load operation fails in prepare_primary_index.
• be/src/storage/lake/update_manager.cpp: Added code to release the lock guard before removing the index entry if the prepare operation fails in prepare_primary_index.

New test case:

• be/test/storage/lake/primary_key_publish_test.cpp: Added a new test case test_index_load_failure to LakePrimaryKeyPublishTest to verify the behavior when index load fails.

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.4
  • 3.3
  • 3.2
  • 3.1
  • 3.0

[github-actions]

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	src/storage/lake/update_manager.cpp	4	4	100.00%	[]

[github-actions]

@Mergifyio backport branch-3.4

[github-actions]

@Mergifyio backport branch-3.3

[github-actions]

@Mergifyio backport branch-3.2

[github-actions]

@Mergifyio backport branch-3.1

[mergify]

backport branch-3.4

✅ Backports have been created

• #53883 [BugFix] fix lock release issue in cloud native pk table (backport #53878) has been created for branch branch-3.4

[mergify]

backport branch-3.3

✅ Backports have been created

• #53884 [BugFix] fix lock release issue in cloud native pk table (backport #53878) has been created for branch branch-3.3

[mergify]

backport branch-3.2

✅ Backports have been created

• #53882 [BugFix] fix lock release issue in cloud native pk table (backport #53878) has been created for branch branch-3.2

[mergify]

backport branch-3.1

✅ Backports have been created

• #53885 [BugFix] fix lock release issue in cloud native pk table (backport #53878) has been created for branch branch-3.1 but encountered conflicts