Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix list partition multi values' probelm #51036

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

before-Sunrise
Copy link
Contributor

Why I'm doing:

if one partition column has multi values for one partition, like "PARTITION pCalifornia VALUES IN ("Los Angeles","San Francisco","San Diego")", then predicate like "city not in "Los Angeles" " can not be used to prune the whole partition.

What I'm doing:

Right now we don't support multi values partition's partition prune, so just forbid it for "not in" for the correctness of query.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@before-Sunrise before-Sunrise requested a review from a team as a code owner September 14, 2024 03:25
@before-Sunrise before-Sunrise requested a review from a team as a code owner September 14, 2024 03:28
Copy link

sonarcloud bot commented Sep 14, 2024

@before-Sunrise before-Sunrise force-pushed the fix_list_partition branch 3 times, most recently from 34f030f to 14cf422 Compare November 1, 2024 08:39
Signed-off-by: before-Sunrise <[email protected]>
Copy link

sonarcloud bot commented Nov 1, 2024

Copy link

github-actions bot commented Nov 1, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 1, 2024

[FE Incremental Coverage Report]

pass : 6 / 7 (85.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/ListPartitionPruner.java 6 7 85.71% [717]

Copy link

github-actions bot commented Nov 1, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link
Contributor

@LiShuMing LiShuMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. We may add a TODO to support multi-value partition pruing.

@wyb wyb merged commit f3ba5b8 into StarRocks:main Nov 4, 2024
51 checks passed
Copy link

github-actions bot commented Nov 4, 2024

@Mergifyio backport branch-3.3

Copy link

github-actions bot commented Nov 4, 2024

@Mergifyio backport branch-3.2

Copy link
Contributor

mergify bot commented Nov 4, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 4, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 4, 2024
Signed-off-by: before-Sunrise <[email protected]>
(cherry picked from commit f3ba5b8)
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
Signed-off-by: before-Sunrise <[email protected]>
(cherry picked from commit f3ba5b8)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/PartitionPruneTest.java
wanpengfei-git pushed a commit that referenced this pull request Nov 7, 2024
silverbullet233 pushed a commit that referenced this pull request Nov 7, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
kangkaisen pushed a commit that referenced this pull request Nov 15, 2024
kangkaisen pushed a commit that referenced this pull request Nov 18, 2024
kangkaisen pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants