-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue 38 password keyboard behaviour #43
Conversation
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
============================================
+ Coverage 25.97% 27.54% +1.58%
- Complexity 195 228 +33
============================================
Files 102 105 +3
Lines 2916 3102 +186
Branches 403 439 +36
============================================
+ Hits 757 854 +97
- Misses 2122 2196 +74
- Partials 37 52 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Thank you for taking a look at this and fixing the issues in smaller targeted PRs @Basler182 🚀 |
# *Fix/issue 32 leading aligned icons register* Could be either merged into #43 or main once #43 is merged ## ♻️ Current situation & Problem #32 ## ⚙️ Release Notes - IconLeadingContent Composable - Adapted RegisterScreen accordingly ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md). --------- Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/login/LoginViewModel.kt
Show resolved
Hide resolved
...anford/spezi/core/design/component/validated/outlinedtextfield/ValidatedOutlinedTextField.kt
Outdated
Show resolved
Hide resolved
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/login/LoginFormValidator.kt
Outdated
Show resolved
Hide resolved
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/register/FormValidator.kt
Show resolved
Hide resolved
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/login/LoginFormValidator.kt
Outdated
Show resolved
Hide resolved
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/register/RegisterViewModel.kt
Outdated
Show resolved
Hide resolved
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/register/RegisterViewModel.kt
Outdated
Show resolved
Hide resolved
modules/account/src/test/java/edu/stanford/spezi/module/account/login/LoginFormValidatorTest.kt
Outdated
Show resolved
Hide resolved
modules/account/src/test/java/edu/stanford/spezi/module/account/login/LoginViewModelTest.kt
Outdated
Show resolved
Hide resolved
...anford/spezi/core/design/component/validated/outlinedtextfield/ValidatedOutlinedTextField.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Let's set as a goal for future PRs to have as less codecov complains comments for untested lines as possible 😄
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
modules/account/src/main/kotlin/edu/stanford/spezi/module/account/register/FormValidator.kt
Show resolved
Hide resolved
.../account/src/main/kotlin/edu/stanford/spezi/module/account/register/RegisterFormValidator.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Fix/issue 38 password keyboard behaviour
♻️ Current situation & Problem
#38
⚙️ Release Notes
✅ Testing
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: