Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password Keyboard Behaviour #38

Closed
1 task done
PSchmiedmayer opened this issue Jun 11, 2024 · 0 comments
Closed
1 task done

Password Keyboard Behaviour #38

PSchmiedmayer opened this issue Jun 11, 2024 · 0 comments
Assignees
@Basler182
Labels
bug An unexpected problem ENGAGE HF ENGAGE-HF-specific issues good first issue Good for newcomers

Comments

@PSchmiedmayer
Copy link
Member

Description

When entering a password in the password text field the submit button on the keyboard toggles the password to plain text instead of submitting the password + username to log in.

Reproduction

  1. Navigate to the login screen
  2. Enter a username and password
  3. Press the submit button on the keyboard.

Expected behavior

The keyboard should be stabled and a loading view should indicate the loading progress that the login is performed. All other buttons should be disabled.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@PSchmiedmayer PSchmiedmayer added bug An unexpected problem ENGAGE HF ENGAGE-HF-specific issues labels Jun 11, 2024
@PSchmiedmayer PSchmiedmayer moved this from Backlog to Next Steps in Project Planning Jun 11, 2024
@PSchmiedmayer PSchmiedmayer added the good first issue Good for newcomers label Jun 11, 2024
@Basler182 Basler182 self-assigned this Jun 13, 2024
@Basler182 Basler182 mentioned this issue Jun 14, 2024
Merged
1 task
Basler182 added a commit that referenced this issue Jun 22, 2024
@Basler182
Updated login screen
9c33498 
# *Fix/issue 38 password keyboard behaviour*

## ♻️ Current situation & Problem
#38 


## ⚙️ Release Notes 

- Added Password Toogle Icon to Login Screen
- Added Login Form Validator
- Added Login Error Cases 
- Switched to OutlinedTextFields


## ✅ Testing
- Added CredentialRegisterManagerAuthTest
- Added LoginViewModelTest
- Added LoginFormValidatorTest


## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).

---------

Signed-off-by: Basler182 <[email protected]>
@github-project-automation github-project-automation bot moved this from Next Steps to Done in Project Planning Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Basler182 Basler182

Labels
bug An unexpected problem ENGAGE HF ENGAGE-HF-specific issues good first issue Good for newcomers
Projects
Project Planning
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PSchmiedmayer @Basler182