Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Raven v 1.8.3 #783

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Adding Raven v 1.8.3 #783

merged 5 commits into from
Nov 7, 2023

Conversation

deemalone
Copy link
Contributor

@deemalone deemalone commented Nov 6, 2023

updating raven to 1.8.3 from 1.8.1 for the docker builds workshop;
lbcb-sci's raven verison 1.8.3 has added CreateUnitigGraph, added PrintUnitigGfa, and updated bugs

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

updated to 1.8.3
to include 1.8.3 to the list of raven versions available
@erinyoung erinyoung changed the title Create Dockerfile Adding Raven v 1.8.3 Nov 7, 2023
Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@erinyoung
Copy link
Contributor

I made a small change to the Dockerfile by adding in a CMD raven --help instruction, which triggered the github action testing again.

This looks great! Thank you for your contribution!

Once testing passes, I will

  1. merge this PR
  2. push to dockerhub and quay with the tag 1.8.3
  3. overwrite the latest tag

@erinyoung erinyoung merged commit c6aa25f into StaPH-B:master Nov 7, 2023
2 checks passed
@erinyoung
Copy link
Contributor

Thank you again for your contribution!

You can check the status of the deploy at https://github.com/StaPH-B/docker-builds/actions/runs/6788757963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants