Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request An Update]: raven #717

Closed
erinyoung opened this issue Aug 30, 2023 · 9 comments
Closed

[Request An Update]: raven #717

erinyoung opened this issue Aug 30, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@erinyoung
Copy link
Contributor

What container needs an update?

There's a new version of raven : 1.8.2

All the version release says is "bug fixes" (https://github.com/lbcb-sci/raven/releases/tag/1.8.2)

@erinyoung erinyoung added the enhancement New feature or request label Aug 30, 2023
@deemalone
Copy link
Contributor

Oooooo ravens! I'll choose this one for the Docker training! Thanks!

@erinyoung
Copy link
Contributor Author

Perfect!

Ravens are cool, and so is long-read assembly.

@erinyoung
Copy link
Contributor Author

@deemalone , are you still working on this?

@deemalone
Copy link
Contributor

Yes! Apologies, it's taking me a while.
Ran into some issues that I'm trying to figure out.
Unless . . . I'm holding you up?
I won't be offended if you have to cut me loose.
But, yes, I'm still working on it.

@kapsakcj
Copy link
Collaborator

kapsakcj commented Nov 1, 2023

@deemalone We would be happy to help troubleshoot the issues you're encountering!

I can't speak for Erin, but you're not holding me up 😄 I think she was checking in to see how things are going

@deemalone
Copy link
Contributor

Oh, thank goodness! I've taken so long they've released a 1.8.3! 😅

For 1.8.2, I went down a rabbit hole of "compare the code" and "what am I supposed to do again?" when I think all I had to do was switch the version in the dockerfile, no?

I couldn't figure out how to fork (the option seems to be missing at the top of my browser no matter where I navigate) but I downloaded the 1.8.1 dockerfile, changed the version info, uploaded it to my GitHub, pulled it into Gitpod, built an image from the dockerfile, hopped into the container and saw that the ERA-files were generated. So, I think that means it worked . . . I think.

THEN (for confirmation) I tried using docker build -t old --build-arg="RAVEN_VERSION=1.8.1" . to build an older version of raven and got the same ERA-files which should happen because the test files would be the same in the dockerfile regardless of the version. So, I think that means it worked . . . I think. . . right? 🤔

@erinyoung
Copy link
Contributor Author

THEN (for confirmation) I tried using docker build -t old --build-arg="RAVEN_VERSION=1.8.1" . to build an older version of raven and got the same ERA-files which should happen because the test files would be the same in the dockerfile regardless of the version. So, I think that means it worked . . . I think. . . right? 🤔

Yes! It is probably working.

You can send me an email to schedule a meeting and you can share your screen to figure out how to fork the github repo.

@deemalone
Copy link
Contributor

Sounds good, thanks! I'll send an email soon!

@erinyoung
Copy link
Contributor Author

Closed by #783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants