Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed old SPAdes URL in Dockerfile for Unicycler 0.5.0 #1121

Closed
wants to merge 1 commit into from

Conversation

broncio123
Copy link

@broncio123 broncio123 commented Dec 11, 2024

Replaced old SPAdes download URL with new one pointing to GitHub repo. Note that other Dockerfile versions will have to be fixed similarly pointing to the corresponding SPAde version.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Replaced old SPAdes download URL with new one pointing to GitHub repo. 
Note that other Dockerfile versions will have to be fixed similarly pointing to the corresponding SPAde version.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image built successfully from modified Dockerfile. Unicycler runs successfully too.

@erinyoung
Copy link
Contributor

Thank you for looking into this!

We try not to overwrite tags on dockerhub and quay, so the tag for the newly built image would be something like 0.5.0-{spades ver} or 0.5.0-202412

I think it'd be more worthwhile to create a new Dockerfile for unicycler version 0.5.1 with this update. What do you think?

@broncio123
Copy link
Author

Thank you for looking into this!

We try not to overwrite tags on dockerhub and quay, so the tag for the newly built image would be something like 0.5.0-{spades ver} or 0.5.0-202412

I think it'd be more worthwhile to create a new Dockerfile for unicycler version 0.5.1 with this update. What do you think?

I will pick the second option. I will add my Dockerfile and README into a folder named 0.5.1.
I will close this PR and submit a new one soon. Thanks! @erinyoung

@broncio123 broncio123 closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants