Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds blast 2.16.0 #1048

Merged
merged 1 commit into from
Sep 20, 2024
Merged

adds blast 2.16.0 #1048

merged 1 commit into from
Sep 20, 2024

Conversation

Kincekara
Copy link
Collaborator

Closes #1028

diff blast/2.15.0/Dockerfile blast/2.16.0/Dockerfile
3c3
< ARG BLAST_VER="2.15.0"
---
> ARG BLAST_VER="2.16.0"
25,26c25
<   rm ncbi-blast-${BLAST_VER}+-x64-linux.tar.gz && \
<   mkdir /data
---
>   rm ncbi-blast-${BLAST_VER}+-x64-linux.tar.gz
36d34
< # default command is to pull up help options for virulencefinder
diff blast/2.15.0/README.md blast/2.16.0/README.md
9c9
< blast+ is actually a suite of tools. blast+ v.2.15.0 includes:
---
> blast+ is actually a suite of tools. blast+ v.2.16.0 includes:

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together!

I have no changes to recommend.

I'm going to

  1. merge this PR
  2. deploy this to 'staphb/blast' on both dockerhub and quay
  3. will tag with the values of both '2.16.0' and 'latest'

@erinyoung erinyoung merged commit 4b96906 into StaPH-B:master Sep 20, 2024
2 checks passed
@erinyoung
Copy link
Contributor

You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/10963421711

@Kincekara Kincekara deleted the blast branch September 20, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request An Update]: blast
2 participants