Don't error if our conditional GET fails. #176
Conversation
|
I shoehorned this into an app and it actually does what it should 🎉 |
| NSLog(@"Error removing temporary download directory at %@: %@", downloadDirectory, error.sqrl_verboseDescription); | ||
| } | ||
| }; | ||
|
|
||
| return [[[self | ||
| downloadBundleForUpdate:update intoDirectory:downloadDirectory] |
There was a problem hiding this comment.
Is there any way we could have the download signal return the already downloaded URL from the cache to save these if nil branches?
There was a problem hiding this comment.
What we really need is a monad transformer for RAC.
But anyways, I like that idea, but essentially all the branches are avoiding doing things with the zip, which we understandably don't keep around after unzipping.
There was a problem hiding this comment.
What we really need is a monad transformer for RAC.
Tell me more :thinking_face:
But anyways, I like that idea, but essentially all the branches are avoiding doing things with the zip
Hmm that’s a good point, can we structure it so that we return a signal from inside the conditional get that is flattened, then we can branch on whether we have a zip to decompress or can fulfill the unarchived update from the cache?
There was a problem hiding this comment.
I reorganized so we can avoid all the annoying nil checks. We're still providing a nil bundle because we want to distinguish between the case where we just downloaded the update and want to verify it, and the case where we already have it and just need to clean up the temp directory.
|
👍 this looks good to me |
This was caused by #175 and #171.
If we tried to download an update and our conditional GET says we already have it, we’d throw an error later when we tried to find the app bundle that we didn't download:
Squirrel.Mac/Squirrel/SQRLUpdater.m
Line 460 in 9ebfd39
That meant we wouldn’t end up in the
SQRLUpdaterStateAwaitingRelaunchstate, and so we’d prune the already downloaded update, and still experience #174.