Conditionally download updates. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This assumes we can trust servers to return and respect etags. Is that a reasonable assumption these days? |
|
Looks like S3 respects etags which I gotta think is where most updates live. |
| @@ -40,6 +40,10 @@ @interface SQRLUpdater () | |||
|
|
|||
| @property (atomic, readwrite) SQRLUpdaterState state; | |||
|
|
|||
| /// The etag of the currently downloaded update, nil if no update has been | |||
| /// downloaded. | |||
| @property (atomic, copy) NSString *etag; | |||
There was a problem hiding this comment.
Does this need to be atomic, inside the scope of the RACCommand shouldn’t access be serialised?
There was a problem hiding this comment.
LOL I honestly couldn't recall anymore, so I went with safe over sorry.
|
I don’t think we lose anything with the |
This was referenced Jun 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111