BED-5323 fixing build issues #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * Update GetDomainEntityInfo() to use the FetchEnforcedGPOs function. * Added a test case for FetchEnforcedGPOsPaths() * Fix ReadTransactionTestWithSetup(), txDelegate was never called. Looks like it was a copy/paste error in commit 42efe25 --------- Co-authored-by: John Hopper <[email protected]>
* added check for accept header. working on filtering refactor * chore: updated error message * updated docs * ran prepare-for-codereview * removed display fields from docs * more clean up * more cleanup * fix: marshalling csv could return a 200 when it was broken * chore: update docs to fix a miss --------- Co-authored-by: Alyx Holms <[email protected]>
maffkipp
approved these changes
Jan 28, 2025
benwaples
approved these changes
Jan 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds fields for new tooltip data.
Motivation and Context
This PR addresses: https://specterops.atlassian.net/browse/BED-5323
Why is this change required? What problem does it solve?
This is needed for the new tooltip to display change data.
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Tested via existing unit tests.
Screenshots (optional):
Types of changes
Checklist: