S1144: Add repro for #8342 #8354
Conversation
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned antonioaversa
| namespace Tests.Diagnostics | ||
| using System; | ||
|
|
||
| namespace Tests.Diagnostics |
There was a problem hiding this comment.
I'm surprised you haven't fought your war against block-scoped namespaces for this file 😄
Edit: nevermind, I saw that it namespaces have some actual purpose here
There was a problem hiding this comment.
Yes, in this case there are other namespaces, so I could not easily go for it :-)
| // https://github.com/SonarSource/sonar-dotnet/issues/8342 | ||
| class Repro_8342 | ||
| { | ||
| [Private1] public void APublicMethod() => APrivateMethodCalledByAPublicMethod(); |
There was a problem hiding this comment.
Maybe it's also worth adding a test case with multiple attributes (and list attributes):
[SomePublicAttribute, Private1]
public void Something() { }
[SomePublicAttribute]
[Private1]
public void Something2() { }
github-actions
bot
assigned antonioaversa and unassigned cristian-ambrosini-sonarsource
antonioaversa
force-pushed
the
antonio/S1144-repro-8342
branch
from
d0e6954 to
36de33b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Reproduces #8342