Skip to content

Commit

Permalink
S1144: Add repro for #8342 (#8354)
Browse files Browse the repository at this point in the history
  • Loading branch information
@antonioaversa
antonioaversa authored Nov 16, 2023
1 parent 94f71e4 commit c746b74
Show file tree
Hide file tree
Showing 5 changed files with 203 additions and 159 deletions.
314 changes: 156 additions & 158 deletions analyzers/tests/SonarAnalyzer.UnitTest/TestCases/UnusedPrivateMember.CSharp7.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,218 +4,216 @@
using System.Runtime.Serialization;
using System.Threading.Tasks;

namespace Tests.Diagnostics
public class ExpressionBodyProperties
{
public class ExpressionBodyProperties
{
private int field;
private int field;

private int Property01
{
get => field;
set => field = value; // Noncompliant
}
private int Property01
{
get => field;
set => field = value; // Noncompliant
}

private int Property02
{
get => field; // Noncompliant
set => field = value;
}
private int Property02
{
get => field; // Noncompliant
set => field = value;
}

public void Method()
{
int x;
public void Method()
{
int x;

x = Property01;
Property02 = x;
}
x = Property01;
Property02 = x;
}
}

// https://github.com/SonarSource/sonar-dotnet/issues/2478
public class ReproIssue2478
// https://github.com/SonarSource/sonar-dotnet/issues/2478
public class ReproIssue2478
{
public void SomeMethod()
{
public void SomeMethod()
{
var (a, (barA, barB)) = new PublicDeconstructWithInnerType();
var (a, (barA, barB)) = new PublicDeconstructWithInnerType();

var (_, _, c) = new PublicDeconstruct();
var (_, _, c) = new PublicDeconstruct();

var qix = new MultipleDeconstructors();
object b;
(a, b, c) = qix;
var qix = new MultipleDeconstructors();
object b;
(a, b, c) = qix;

(a, b) = ReturnFromMethod();
(a, b) = ReturnFromMethod();

(a, b) = new ProtectedInternalDeconstruct();
(a, b) = new ProtectedInternalDeconstruct();

(a, b, c) = new Ambiguous(); // Error [CS0121]
(a, b) = new NotUsedDifferentArgumentCount(); // Error [CS7036,CS8129]
(a, b) = new NotUsedNotVisible(); // Error [CS7036,CS8129]
}

internal void InternalMethod(InternalDeconstruct bar)
{
var (a, b) = bar;
}
(a, b, c) = new Ambiguous(); // Error [CS0121]
(a, b) = new NotUsedDifferentArgumentCount(); // Error [CS7036,CS8129]
(a, b) = new NotUsedNotVisible(); // Error [CS7036,CS8129]
}

private sealed class PublicDeconstructWithInnerType
{
public void Deconstruct(out object a, out InternalDeconstruct b) { a = b = null; }
internal void InternalMethod(InternalDeconstruct bar)
{
var (a, b) = bar;
}

// deconstructors must be public, internal or protected internal
private void Deconstruct(out object a, out object b) { a = b = null; } // Noncompliant
}
private sealed class PublicDeconstructWithInnerType
{
public void Deconstruct(out object a, out InternalDeconstruct b) { a = b = null; }

internal sealed class InternalDeconstruct
{
internal void Deconstruct(out object a, out object b) { a = b = null; }
// deconstructors must be public, internal or protected internal
private void Deconstruct(out object a, out object b) { a = b = null; } // Noncompliant
}

// deconstructors must be public, internal or protected internal
private void Deconstruct(out object a, out string b, out string c) { a = b = c = null; } // Noncompliant
}
internal sealed class InternalDeconstruct
{
internal void Deconstruct(out object a, out object b) { a = b = null; }

private class PublicDeconstruct
{
public void Deconstruct(out object a, out object b, out object c) { a = b = c = null; }
// deconstructors must be public, internal or protected internal
private void Deconstruct(out object a, out string b, out string c) { a = b = c = null; } // Noncompliant
}

// deconstructors must be public, internal or protected internal
protected void Deconstruct(out string a, out string b, out string c) { a = b = c = null; } // Noncompliant
private void Deconstruct(out object a, out string b, out string c) { a = b = c = null; } // Noncompliant
}
private class PublicDeconstruct
{
public void Deconstruct(out object a, out object b, out object c) { a = b = c = null; }

private sealed class MultipleDeconstructors
{
public void Deconstruct(out object a, out object b, out object c) { a = b = c = null; }
// deconstructors must be public, internal or protected internal
protected void Deconstruct(out string a, out string b, out string c) { a = b = c = null; } // Noncompliant
private void Deconstruct(out object a, out string b, out string c) { a = b = c = null; } // Noncompliant
}

public void Deconstruct(out object a, out object b) // Noncompliant
{
a = b = null;
}
}
private sealed class MultipleDeconstructors
{
public void Deconstruct(out object a, out object b, out object c) { a = b = c = null; }

private class ProtectedInternalDeconstruct
public void Deconstruct(out object a, out object b) // Noncompliant
{
protected internal void Deconstruct(out object a, out object b) { a = b = null; }

protected internal void Deconstruct(out object a, out object b, out object c) { a = b = c = null; } // Noncompliant
a = b = null;
}
}

private class Ambiguous
{
public void Deconstruct(out string a, out string b, out string c) { a = b = c = null; }
public void Deconstruct(out object a, out object b, out object c) { a = b = c = null; } // Noncompliant FP, actually the one above is not used
}
private class ProtectedInternalDeconstruct
{
protected internal void Deconstruct(out object a, out object b) { a = b = null; }

private class NotUsedDifferentArgumentCount
{
public void Deconstruct(out string a, out string b, out string c) { a = b = c = null; } // Noncompliant
public void Deconstruct(out string a, out string b, out string c, out string d) { a = b = c = d = null; } // Noncompliant
}
protected internal void Deconstruct(out object a, out object b, out object c) { a = b = c = null; } // Noncompliant
}

private class NotUsedNotVisible
{
protected void Deconstruct(out object a, out object b) { a = b = null; } // Noncompliant
private void Deconstruct(out string a, out string b) { a = b = null; } // Noncompliant
}
private class Ambiguous
{
public void Deconstruct(out string a, out string b, out string c) { a = b = c = null; }
public void Deconstruct(out object a, out object b, out object c) { a = b = c = null; } // Noncompliant FP, actually the one above is not used
}

private ForMethod ReturnFromMethod() => null;
private sealed class ForMethod
{
public void Deconstruct(out object a, out object b) { a = b = null; }
}
private class NotUsedDifferentArgumentCount
{
public void Deconstruct(out string a, out string b, out string c) { a = b = c = null; } // Noncompliant
public void Deconstruct(out string a, out string b, out string c, out string d) { a = b = c = d = null; } // Noncompliant
}

public class ReproIssue2333
private class NotUsedNotVisible
{
public void Method()
{
PrivateNestedClass x = new PrivateNestedClass();
(x.ReadAndWrite, x.OnlyWriteNoBody, x.OnlyWrite) = ("A", "B", "C");
var tuple = (x.ReadAndWrite, x.OnlyRead);
}
protected void Deconstruct(out object a, out object b) { a = b = null; } // Noncompliant
private void Deconstruct(out string a, out string b) { a = b = null; } // Noncompliant
}

private class PrivateNestedClass
{
private string hasOnlyWrite;

public string ReadAndWrite { get; set; } // Setters are compliant, they are used in tuple assignment
public string OnlyWriteNoBody { get; set; } // Compliant, we don't raise on get without body

public string OnlyRead
{
get;
set; // Noncompliant
}

public string OnlyWrite
{
get => hasOnlyWrite; // Noncompliant
set => hasOnlyWrite = value;
}
}
private ForMethod ReturnFromMethod() => null;
private sealed class ForMethod
{
public void Deconstruct(out object a, out object b) { a = b = null; }
}
}

public class ReproIssue2333
{
public void Method()
{
PrivateNestedClass x = new PrivateNestedClass();
(x.ReadAndWrite, x.OnlyWriteNoBody, x.OnlyWrite) = ("A", "B", "C");
var tuple = (x.ReadAndWrite, x.OnlyRead);
}

// https://github.com/SonarSource/sonar-dotnet/issues/2752
public class ReproIssue2752
private class PrivateNestedClass
{
private struct PrivateStructRef
private string hasOnlyWrite;

public string ReadAndWrite { get; set; } // Setters are compliant, they are used in tuple assignment
public string OnlyWriteNoBody { get; set; } // Compliant, we don't raise on get without body

public string OnlyRead
{
public uint part1; // Noncompliant FP. Type is communicated an external call.
get;
set; // Noncompliant
}

private class PrivateClassRef
public string OnlyWrite
{
public uint part1; // Noncompliant FP. Type is communicated an external call.
get => hasOnlyWrite; // Noncompliant
set => hasOnlyWrite = value;
}

[DllImport("user32.dll")]
private static extern bool ExternalMethodWithStruct(ref PrivateStructRef reference);

[DllImport("user32.dll")]
private static extern bool ExternalMethodWithClass(ref PrivateClassRef reference);
}
}

public class EmptyCtor
// https://github.com/SonarSource/sonar-dotnet/issues/2752
public class ReproIssue2752
{
private struct PrivateStructRef
{
// That's invalid syntax, but it is still empty ctor and we should not raise for it, even if it is not used
public EmptyCtor() => // Error [CS1525,CS1002]
public uint part1; // Noncompliant FP. Type is communicated an external call.
}

public class WithEnums
private class PrivateClassRef
{
private enum X // Noncompliant
{
A
}
public uint part1; // Noncompliant FP. Type is communicated an external call.
}

public void UseEnum()
{
var b = Y.B;
}
[DllImport("user32.dll")]
private static extern bool ExternalMethodWithStruct(ref PrivateStructRef reference);

private enum Y
{
A,
B
}
[DllImport("user32.dll")]
private static extern bool ExternalMethodWithClass(ref PrivateClassRef reference);
}

public class EmptyCtor
{
// That's invalid syntax, but it is still empty ctor and we should not raise for it, even if it is not used
public EmptyCtor() => // Error [CS1525,CS1002]
}

public class WithEnums
{
private enum X // Noncompliant
{
A
}

// https://github.com/SonarSource/sonar-dotnet/issues/6699
public class Repro_6699
public void UseEnum()
{
public void MethodUsingLocalMethod()
{
void LocalMethod() { } // FN
}
var b = Y.B;
}

// https://github.com/SonarSource/sonar-dotnet/issues/6724
public class Repro_6724
private enum Y
{
public int PrivateGetter { private get; set; } // FN
public int PrivateSetter { get; private set; } // FN
A,
B
}
}

public int ExpressionBodiedPropertyWithPrivateGetter { private get => 1; set => _ = value; } // FN
public int ExpressionBodiedPropertyWithPrivateSetter { get => 1; private set => _ = value; } // FN
// https://github.com/SonarSource/sonar-dotnet/issues/6699
public class Repro_6699
{
public void MethodUsingLocalMethod()
{
void LocalMethod() { } // FN
}
}

// https://github.com/SonarSource/sonar-dotnet/issues/6724
public class Repro_6724
{
public int PrivateGetter { private get; set; } // FN
public int PrivateSetter { get; private set; } // FN

public int ExpressionBodiedPropertyWithPrivateGetter { private get => 1; set => _ = value; } // FN
public int ExpressionBodiedPropertyWithPrivateSetter { get => 1; private set => _ = value; } // FN
}

16 changes: 15 additions & 1 deletion analyzers/tests/SonarAnalyzer.UnitTest/TestCases/UnusedPrivateMember.CSharp8.cs
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
namespace Tests.Diagnostics
using System;

namespace Tests.Diagnostics
{
public interface MyInterface1
{
Expand Down Expand Up @@ -147,3 +149,15 @@ public void SomeMethod()
}
}

// https://github.com/SonarSource/sonar-dotnet/issues/8342
public class Repro_8342
{
[Private1] private protected void APrivateProtectedMethod() { }
[Public1, Private2] public void APublicMethodWithMultipleAttributes1() { }
[Public1][Private2] public void APublicMethodWithMultipleAttributes2() { }

private class Private1Attribute : Attribute { } // Noncompliant: FP: attribute used on a private protected method
private class Private2Attribute : Attribute { } // Noncompliant: FP: attribute used on a public method
private class Private3Attribute : Attribute { } // Noncompliant: FP: attribute used on a public method
public class Public1Attribute : Attribute { } // Compliant: public
}
Loading

0 comments on commit c746b74

Please sign in to comment.