Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate S6299: Disabling Vue.js built-in escaping is security-sensitive #4541

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

loris-s-sonarsource
Copy link
Contributor

This rule is not consistent with the rule quality the AppSec squad enforces:

The rule risks a non-negligible number of FPs for the chance of having TPs.
It is non-productive as TPs would get drowned in between FPs. we lose credibility and engagement even if we do find TPs

The rule is hardly actionable as is, as it only shows a “sink”, not the rest of where the variable is coming from, to check if it is an actual problem

Security Hotspots are meant to raise issues that require data that cannot be put in the same code base, such as organizational needs. The why of the rule seems related to the fact that the analyzer does not support VueJS and the specificator still wanted to make a move.
This is not a standard practice at AppSec and does not follow the company delivery model

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loris-s-sonarsource loris-s-sonarsource merged commit 59d8084 into master Nov 26, 2024
11 checks passed
@loris-s-sonarsource loris-s-sonarsource deleted the loris/APPSEC-2288/Deprecate-S6299 branch November 26, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants