Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS-464 Update ESLint plugin metadata and fix scripts #4964

Merged
merged 2 commits into from
Nov 29, 2024
Merged

JS-464 Update ESLint plugin metadata and fix scripts #4964

merged 2 commits into from
Nov 29, 2024

Conversation

saberduck
Copy link
Contributor

@saberduck saberduck commented Nov 29, 2024 •
edited by jira bot
Loading

@saberduck saberduck requested a review from vdiez November 29, 2024 09:54
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Update ESLint plugin metadata and fix scripts JS-464 Update ESLint plugin metadata and fix scripts Nov 29, 2024
vdiez
vdiez requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please limit changes to new number of rules in README and the fix on count-rules

packages/jsts/src/rules/S6299/meta.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tools/generate-meta.ts Outdated Show resolved Hide resolved
@saberduck saberduck requested a review from vdiez November 29, 2024 14:25
@saberduck saberduck enabled auto-merge (squash) November 29, 2024 14:25
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@saberduck saberduck merged commit dd5d24e into master Nov 29, 2024
18 of 19 checks passed
@saberduck saberduck deleted the update_meta branch November 29, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdiez vdiez vdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberduck @vdiez