Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify S2053(C#): Improve code sample #4452

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Modify S2053(C#): Improve code sample #4452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rules/S2053/csharp/how-to-fix-it/dot-net.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ using System.Security.Cryptography;

public static void hash(string password)
{
var hashed = new Rfc2898DeriveBytes(password, 32, 10000, HashAlgorithmName.SHA256);
var saltSize = 32;
var iterations = 100_000;
hendrik-buchwald-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
var hashed = new Rfc2898DeriveBytes(password, saltSize, iterations, HashAlgorithmName.SHA512);
}
----

Expand Down