Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify S2053(C#): Improve code sample #4452

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Modify S2053(C#): Improve code sample #4452

merged 1 commit into from
Oct 30, 2024

Conversation

loris-s-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@loris-s-sonarsource loris-s-sonarsource self-assigned this Oct 29, 2024
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

hendrik-buchwald-sonarsource
hendrik-buchwald-sonarsource approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small detail; see the comment.

rules/S2053/csharp/how-to-fix-it/dot-net.adoc Show resolved Hide resolved
@loris-s-sonarsource loris-s-sonarsource merged commit d662fdf into master Oct 30, 2024
9 of 10 checks passed
@loris-s-sonarsource loris-s-sonarsource deleted the appsec-2074/loris branch October 30, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource approved these changes

Assignees

@loris-s-sonarsource loris-s-sonarsource

Labels
dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loris-s-sonarsource @hendrik-buchwald-sonarsource