Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S7118 String methods should be used to query content instead of C apis CPP-5790 #4381

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Create rule S7118 String methods should be used to query content instead of C apis CPP-5790 #4381

merged 6 commits into from
Nov 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 7, 2024

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the cfamily C / C++ / Objective-C label Oct 7, 2024
@frederic-tingaud-sonarsource frederic-tingaud-sonarsource changed the title Create rule S7118 Create rule S7118 Redundant calls to underlying char representation of strings should be avoided Oct 7, 2024
@frederic-tingaud-sonarsource frederic-tingaud-sonarsource changed the title Create rule S7118 Redundant calls to underlying char representation of strings should be avoided Create rule S7118 Redundant calls to underlying char representation of strings should be avoided CPP-3435 Oct 7, 2024
@frederic-tingaud-sonarsource frederic-tingaud-sonarsource changed the title Create rule S7118 Redundant calls to underlying char representation of strings should be avoided CPP-3435 Create rule S7118 Redundant calls to underlying char representation of strings should be avoided CPP-5790 Oct 9, 2024
@frederic-tingaud-sonarsource frederic-tingaud-sonarsource marked this pull request as ready for review October 9, 2024 17:52
tomasz-kaminski-sonarsource
tomasz-kaminski-sonarsource requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do grammarly pass on the rspec. You can easily do that by using Edit file option, to see suggestions in browser.

rules/S7118/cfamily/rule.adoc Outdated Show resolved Hide resolved
rules/S7118/cfamily/rule.adoc Outdated Show resolved Hide resolved
rules/S7118/cfamily/rule.adoc Outdated Show resolved Hide resolved
rules/S7118/cfamily/rule.adoc Show resolved Hide resolved
rules/S7118/cfamily/rule.adoc Outdated Show resolved Hide resolved
@tomasz-kaminski-sonarsource tomasz-kaminski-sonarsource changed the title Create rule S7118 Redundant calls to underlying char representation of strings should be avoided CPP-5790 Create rule S7118 tring methods should be used to query content instead of C apis CPP-5790 Oct 10, 2024
@tomasz-kaminski-sonarsource tomasz-kaminski-sonarsource changed the title Create rule S7118 tring methods should be used to query content instead of C apis CPP-5790 Create rule S7118 String methods should be used to query content instead of C apis CPP-5790 Oct 10, 2024
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource merged commit 2c08a31 into master Nov 7, 2024
9 of 10 checks passed
@frederic-tingaud-sonarsource frederic-tingaud-sonarsource deleted the rule/add-RSPEC-S7118 branch November 7, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasz-kaminski-sonarsource tomasz-kaminski-sonarsource tomasz-kaminski-sonarsource approved these changes

Assignees

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource

Labels
cfamily C / C++ / Objective-C
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasz-kaminski-sonarsource @frederic-tingaud-sonarsource