Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S4423, S6378, S6387, S6656: Fix diff view errors in ARM examples #3067

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Modify rule S4423, S6378, S6387, S6656: Fix diff view errors in ARM examples #3067

merged 2 commits into from
Sep 13, 2023

Conversation

egon-okerman-sonarsource
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource commented Sep 13, 2023 •
edited by marco-antognini-sonarsource
Loading

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

This was referenced Sep 13, 2023
Merged
Merged
@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Modify rule S4423,S6378,S6387: Fix diff view errors in examples Modify rule S4423,S6378,S6387,S6656: Fix diff view errors in examples Sep 13, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Modify rule S4423,S6378,S6387,S6656: Fix diff view errors in examples Modify rule S4423, S6378, S6387, S6656: Fix diff view errors in ARM examples Sep 13, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource mentioned this pull request Sep 13, 2023
Merged
4 tasks
@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@egon-okerman-sonarsource egon-okerman-sonarsource mentioned this pull request Sep 13, 2023
Merged
@sonarqube-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

marco-antognini-sonarsource
marco-antognini-sonarsource approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was super fast, thanks a lot!

@egon-okerman-sonarsource egon-okerman-sonarsource merged commit a9c9fb9 into master Sep 13, 2023
9 checks passed
@egon-okerman-sonarsource egon-okerman-sonarsource deleted the bugfix/bicep-diff-view branch September 13, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-antognini-sonarsource marco-antognini-sonarsource marco-antognini-sonarsource approved these changes

Assignees

@marco-antognini-sonarsource marco-antognini-sonarsource

Labels
appsec iac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egon-okerman-sonarsource @marco-antognini-sonarsource