Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S4423: Add language AzureResourceManager (Bicep) #1879

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Modify rule S4423: Add language AzureResourceManager (Bicep) #1879

merged 2 commits into from
Sep 13, 2023

Conversation

egon-okerman-sonarsource
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource commented May 11, 2023 •
edited
Loading

ARM JSON PR for S4423: #1835
RSPEC Preview

@egon-okerman-sonarsource egon-okerman-sonarsource mentioned this pull request May 11, 2023
Merged
egon-okerman-sonarsource added a commit that referenced this pull request May 11, 2023
@egon-okerman-sonarsource
Create rule S4423: add language AzureResourceManager (#1835)
42f4fbd 
[Specification
ticket](https://sonarsource.atlassian.net/browse/SONARIAC-755)
[Implementation
ticket](https://sonarsource.atlassian.net/browse/SONARIAC-781)
[RSPEC
Preview](https://sonarsource.github.io/rspec/#/rspec/S4423/azureresourcemanager)

Bicep PR for S4423: #1879
@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Modify rule S4423: add Bicep to ARM templates Modify rule S4423: Add language AzureResourceManager (Bicep) May 16, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource marked this pull request as ready for review September 4, 2023 10:48
@sonarqube-next
Copy link

sonarqube-next bot commented Sep 4, 2023

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

sonarqube-next bot commented Sep 4, 2023

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonas-wielage-sonarsource jonas-wielage-sonarsource merged commit 897bb45 into master Sep 13, 2023
@jonas-wielage-sonarsource jonas-wielage-sonarsource deleted the rule/S4423/add-bicep branch September 13, 2023 08:25
@marco-antognini-sonarsource
Copy link
Contributor

Hi @jonas-wielage-sonarsource, @egon-okerman-sonarsource
This merge introduced some regressions: https://cirrus-ci.com/task/5986925966786560?logs=asciidoc_tests#L114

[S4423/azureresourcemanager] diff-id=1 has too many noncompliant examples: /tmp/cirrus-ci-build/rules/S4423/azureresourcemanager/how-to-fix-it/azure-mysql.adoc:15, /tmp/cirrus-ci-build/rules/S4423/azureresourcemanager/how-to-fix-it/azure-mysql.adoc:45, /tmp/cirrus-ci-build/rules/S4423/azureresourcemanager/how-to-fix-it/azure-storage-account.adoc:29, /tmp/cirrus-ci-build/rules/S4423/azureresourcemanager/how-to-fix-it/azure-storage-account.adoc:59

Could you please have a look and ensure the ID are unique for the whole rule? You may use a prefix to your IDs per sublanguage like I did in other PRs.

We are very close to enabling the CI check with #2883 but this regression is blocking. Your help is appreciated.

This was referenced Sep 13, 2023
Merged
Merged
@egon-okerman-sonarsource
Copy link
Contributor Author

I'll take care of it ASAP.

@egon-okerman-sonarsource
Copy link
Contributor Author

All blocking regressions should be taken care of in #3067.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
iac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egon-okerman-sonarsource @marco-antognini-sonarsource @jonas-wielage-sonarsource