-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S6378: Add language AzureResourceManager (JSON) #2237
Merged
egon-okerman-sonarsource
merged 7 commits into
master
from
rule/S6378-add-azureresourcemanager
Jun 29, 2023
Merged
Create rule S6378: Add language AzureResourceManager (JSON) #2237
egon-okerman-sonarsource
merged 7 commits into
master
from
rule/S6378-add-azureresourcemanager
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
egon-okerman-sonarsource
changed the title
Create rule S6378
Modify rule S6378: Add language AzureResourceManager (JSON)
Jun 20, 2023
4 tasks
egon-okerman-sonarsource
changed the title
Modify rule S6378: Add language AzureResourceManager (JSON)
Create rule S6378: Add language AzureResourceManager (JSON)
Jun 21, 2023
pierre-loup-tristant-sonarsource
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SonarQube Quality Gate for 'rspec-frontend' |
SonarQube Quality Gate for 'rspec-tools' |
4 tasks
guillaume-dequenne-sonarsource
pushed a commit
that referenced
this pull request
Jul 3, 2023
[Specification ticket](https://sonarsource.atlassian.net/browse/APPSEC-777) [Implementation ticket](https://sonarsource.atlassian.net/browse/SONARIAC-889) [RSPEC Preview](https://sonarsource.github.io/rspec/#/rspec/S6378/azureresourcemanager) Bicep PR for S6378: #2255 ## Review A dedicated reviewer checked the rule description successfully for: - [ ] logical errors and incorrect information - [ ] information gaps and missing content - [ ] text style and tone - [ ] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule) --------- Co-authored-by: egon-okerman-sonarsource <[email protected]> Co-authored-by: Egon Okerman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification ticket
Implementation ticket
RSPEC Preview
Bicep PR for S6378: #2255
Review
A dedicated reviewer checked the rule description successfully for: