Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6378: Add language AzureResourceManager (JSON) #2237

Merged
merged 7 commits into from
Jun 29, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 19, 2023

Specification ticket
Implementation ticket
RSPEC Preview

Bicep PR for S6378: #2255

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Create rule S6378 Modify rule S6378: Add language AzureResourceManager (JSON) Jun 20, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource marked this pull request as ready for review June 20, 2023 15:17
@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Modify rule S6378: Add language AzureResourceManager (JSON) Create rule S6378: Add language AzureResourceManager (JSON) Jun 21, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@egon-okerman-sonarsource egon-okerman-sonarsource merged commit 9619fe4 into master Jun 29, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource deleted the rule/S6378-add-azureresourcemanager branch June 29, 2023 13:58
guillaume-dequenne-sonarsource pushed a commit that referenced this pull request Jul 3, 2023
[Specification
ticket](https://sonarsource.atlassian.net/browse/APPSEC-777)
[Implementation
ticket](https://sonarsource.atlassian.net/browse/SONARIAC-889)
[RSPEC
Preview](https://sonarsource.github.io/rspec/#/rspec/S6378/azureresourcemanager)

Bicep PR for S6378: #2255 

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)

---------

Co-authored-by: egon-okerman-sonarsource <[email protected]>
Co-authored-by: Egon Okerman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants