Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S6380: Add language AzureResourceManager (Bicep) #2298

Merged

Conversation

egon-okerman-sonarsource
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource commented Jun 27, 2023

Specification ticket: APPSEC-775
Implementation ticket: SONARIAC-899
RSPEC Preview

JSON PR for S6380: #2274

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Bicep changes LGTM. You'll probably want to merge/rebase from the JSON-only branch after making any changes based on the review there.

@egon-okerman-sonarsource egon-okerman-sonarsource force-pushed the rule/bicep/S6380-add-azureresourcemanager branch from f836833 to f37b691 Compare July 3, 2023 16:02
egon-okerman-sonarsource added a commit that referenced this pull request Jul 3, 2023
Specification ticket:
[APPSEC-775](https://sonarsource.atlassian.net/browse/APPSEC-775)
Implementation ticket:
[SONARIAC-899](https://sonarsource.atlassian.net/browse/SONARIAC-899)
[RSPEC
Preview](https://sonarsource.github.io/rspec/#/rspec/S6378/azureresourcemanager)

Bicep PR for S6380: #2298 
## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)



[APPSEC-775]:
https://sonarsource.atlassian.net/browse/APPSEC-775?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[SONARIAC-899]:
https://sonarsource.atlassian.net/browse/SONARIAC-899?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: egon-okerman-sonarsource <[email protected]>
Co-authored-by: Egon Okerman <[email protected]>
Co-authored-by: Jamie Anderson <[email protected]>
@egon-okerman-sonarsource egon-okerman-sonarsource marked this pull request as ready for review July 3, 2023 16:05
@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Create rule S6380: Add language AzureResourceManager (Bicep) Modify rule S6380: Add language AzureResourceManager (Bicep) Sep 4, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource force-pushed the rule/bicep/S6380-add-azureresourcemanager branch from f37b691 to bf89696 Compare September 4, 2023 10:25
@sonarqube-next
Copy link

sonarqube-next bot commented Sep 4, 2023

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-next
Copy link

sonarqube-next bot commented Sep 4, 2023

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonas-wielage-sonarsource jonas-wielage-sonarsource merged commit 905365e into master Sep 13, 2023
@jonas-wielage-sonarsource jonas-wielage-sonarsource deleted the rule/bicep/S6380-add-azureresourcemanager branch September 13, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants