Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: support diagnostic notes #1742

Merged
merged 2 commits into from
Jul 26, 2019
Merged

clang-tidy: support diagnostic notes #1742

merged 2 commits into from
Jul 26, 2019

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Jul 23, 2019 •
edited
Loading

This change is Reviewable

@guwirth
clang-tidy: support diagnostic notes
588a65f 
- add error, warning, note samples and tests
- add flow support: note items
- flow items are without ruleId
- refactoring
- close #1720

First draft without test in UI.
@guwirth guwirth added this to the 1.3.0 milestone Jul 23, 2019
@guwirth guwirth self-assigned this Jul 23, 2019
@guwirth guwirth requested a review from ivangalkin July 23, 2019 13:04
@guwirth guwirth mentioned this pull request Jul 25, 2019
Closed
@guwirth guwirth merged commit 5d9f4cc into SonarOpenCommunity:master Jul 26, 2019
@guwirth guwirth mentioned this pull request Jul 28, 2019
Closed
@guwirth guwirth deleted the clang-tidy-flow branch July 29, 2019 11:04
@stalb stalb mentioned this pull request Aug 12, 2019
Closed
@stalb stalb mentioned this pull request Aug 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivangalkin ivangalkin Awaiting requested review from ivangalkin

Assignees

@guwirth guwirth

Labels
enhancement
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

clang-tidy: Support diagnostic notes clang-tidy: modernize-use-nodiscard check message breaks regex
1 participant
@guwirth